Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bulk email templates contains many edX-specific reference (and are thus unusable) #100

Closed
BbrSofiane opened this issue Sep 7, 2021 · 16 comments · Fixed by openedx/edx-platform#29900
Assignees
Labels
bug Report of or fix for something that isn't working as intended
Milestone

Comments

@BbrSofiane
Copy link
Member

BbrSofiane commented Sep 7, 2021

Emails sent via the Bulk Email feature use an edX specific template.

More details in overhangio/tutor#485

@BbrSofiane BbrSofiane added this to the Lilac.3 milestone Sep 7, 2021
@cmltaWt0
Copy link

cmltaWt0 commented Sep 7, 2021

And here we need to design this email template firstly for open edX brand.
Do we have an open edX brand-book already (maybe I miss it somewhere)?

@regisb
Copy link
Contributor

regisb commented Nov 25, 2021

Hi @mdbc-tech! Any news on this?

@BbrSofiane BbrSofiane modified the milestones: Maple.1, Maple.2 Dec 10, 2021
@clemente
Copy link

@mdbc-tech Hi, could you post the status of the task, some work in progress or what's left to do? Thanks

@ziafazal
Copy link

ziafazal commented Jan 7, 2022

@regisb @BbrSofiane @clemente can I pick this up if original assignee is no longer available to look into this issue?

@regisb
Copy link
Contributor

regisb commented Jan 7, 2022

YES!!! ❤️❤️ ❤️

@ziafazal
Copy link

YES!!! ❤️❤️ ❤️

It appears I can't assigne it to myself. Can you assigne it to me?

@ziafazal
Copy link

@regisb I have investigated this issue. It appears we can override both HTML and Text version of Bulk Email temples from django admin(Home › Bulk_Email › Course email templates ›). All we need to do is set Name field of the template empty. Attached screen shot
Screen Shot 2022-01-11 at 1 36 06 PM

@regisb regisb assigned ziafazal and unassigned mdbc-tech Jan 17, 2022
@regisb
Copy link
Contributor

regisb commented Jan 17, 2022

All we need to do is set Name field of the template empty.

What happens when you do this? Does it prevent course emails from being themed at all?

We need to provide users a way to have themed text/html course emails that correspond to their visual identity out of the box. Maybe that the solution requires a change in Tutor, but I suspect that we also need to create new templates that will automatically load static assets from the LMS.

@ziafazal
Copy link

ziafazal commented Jan 24, 2022

Setting Name filed empty means value of Plain template and Html Template fields will be used as Text and Html templates of course emails.

To theme course email users need to put their own templates in Plain template and Html Template fields and set Name field empty. That way users can override default course email templates.

Course email templates can be setup on per site bases too using course_email_template_name site configuration. i.e if we have two sites (example.com and me.com) we can set two different course email templates for both sites. We can create a template using django admin(admin/bulk_email/courseemailtemplate/add/) and set its Name to tamplate_for_example and then create another template and set its Name to tamplate_for_me and then we define a site configuration for both of sites.
e.g for example.com

"course_email_template_name": "tamplate_for_example"

for me.com

"course_email_template_name": "tamplate_for_me"

@ziafazal
Copy link

ziafazal commented Feb 2, 2022

@regisb what are next step on this?

@regisb
Copy link
Contributor

regisb commented Feb 3, 2022

@ziafazal you are right that when we create a custom template and set "Name" to an empty field then that template is used to send emails. The problem is that all users need to create a template that corresponds to their identity. Open edX should ship with a template that works for everyone out of the box. So the next steps would be:

  1. Create a new template that works for everybody.
  2. Make that template the default out of the box.

@ziafazal
Copy link

ziafazal commented Mar 4, 2022

@BbrSofiane how I can move this issue in In progress column?

@ziafazal
Copy link

@regisb @BbrSofiane should we mark this issue as fixed since the PR which provides ability to send bulk course emails via edx-ace got merged?

@regisb
Copy link
Contributor

regisb commented Mar 28, 2022

Hey @ziafazal thanks for your work. Does your PR mean that it is enough to set BULK_EMAIL_SEND_USING_EDX_ACE = True on a vanilla Open edX installation to get rid of the edX theming?

Concerning your PR: I realise that I should have commented there but it flew under my radar. I think that you should create a good default for the BULK_EMAIL_SEND_USING_EDX_ACE in lms/envs/common.py and document the setting such that it appears in https://edx.readthedocs.io/projects/edx-platform-technical/en/latest/

@ziafazal
Copy link

@regisb yes setting BULK_EMAIL_SEND_USING_EDX_ACE to True would send emails via edx-ace and it will use default theming being used for all edx-ace based emails.

BULK_EMAIL_SEND_USING_EDX_ACE setting toggle is already in the docs
https://edx.readthedocs.io/projects/edx-platform-technical/en/latest/featuretoggles.html#featuretoggle-BULK_EMAIL_SEND_USING_EDX_ACE

Its default value is False.

@regisb
Copy link
Contributor

regisb commented Mar 28, 2022

Awesome! Thanks for the quick answer. To close this, I opened the following PR that adds the setting to the default installation in Tutor: overhangio/tutor#621

regisb added a commit to overhangio/tutor that referenced this issue Mar 31, 2022
regisb added a commit to overhangio/tutor that referenced this issue Mar 31, 2022
regisb added a commit to overhangio/tutor that referenced this issue Jun 3, 2022
- 💥 [Feature] Upgrade to Nutmeg: (by @regisb)
    - 💥 [Feature] Persistent grades are now enabled by default.
    - [Bugfix] Remove edX references from bulk emails ([issue](openedx/wg-build-test-release#100)).
    - [Improvement] For Tutor Nightly (and only Nightly), official plugins are now installed from their nightly branches on GitHub instead of a version range on PyPI. This will allow Nightly users to install all official plugins by running ``pip install -e ".[full]"``.
    - [Bugfix] Start MongoDB when running migrations, because a new data migration fails if MongoDB is not running
regisb added a commit to overhangio/tutor that referenced this issue Jun 3, 2022
- 💥 [Feature] Upgrade to Nutmeg: (by @regisb)
    - 💥 [Feature] Persistent grades are now enabled by default.
    - [Bugfix] Remove edX references from bulk emails ([issue](openedx/wg-build-test-release#100)).
    - [Improvement] For Tutor Nightly (and only Nightly), official plugins are now installed from their nightly branches on GitHub instead of a version range on PyPI. This will allow Nightly users to install all official plugins by running ``pip install -e ".[full]"``.
    - [Bugfix] Start MongoDB when running migrations, because a new data migration fails if MongoDB is not running
regisb added a commit to overhangio/tutor that referenced this issue Jun 3, 2022
- 💥 [Feature] Upgrade to Nutmeg: (by @regisb)
    - 💥 [Feature] Persistent grades are now enabled by default.
    - [Bugfix] Remove edX references from bulk emails ([issue](openedx/wg-build-test-release#100)).
    - [Improvement] For Tutor Nightly (and only Nightly), official plugins are now installed from their nightly branches on GitHub instead of a version range on PyPI. This will allow Nightly users to install all official plugins by running ``pip install -e ".[full]"``.
    - [Bugfix] Start MongoDB when running migrations, because a new data migration fails if MongoDB is not running
regisb added a commit to overhangio/tutor that referenced this issue Jun 3, 2022
- 💥 [Feature] Upgrade to Nutmeg: (by @regisb)
    - 💥 [Feature] Persistent grades are now enabled by default.
    - [Bugfix] Remove edX references from bulk emails ([issue](openedx/wg-build-test-release#100)).
    - [Improvement] For Tutor Nightly (and only Nightly), official plugins are now installed from their nightly branches on GitHub instead of a version range on PyPI. This will allow Nightly users to install all official plugins by running ``pip install -e ".[full]"``.
    - [Bugfix] Start MongoDB when running migrations, because a new data migration fails if MongoDB is not running
regisb added a commit to overhangio/tutor that referenced this issue Jun 6, 2022
- 💥 [Feature] Upgrade to Nutmeg: (by @regisb)
    - 💥 [Feature] Persistent grades are now enabled by default.
    - [Bugfix] Remove edX references from bulk emails ([issue](openedx/wg-build-test-release#100)).
    - [Improvement] For Tutor Nightly (and only Nightly), official plugins are now installed from their nightly branches on GitHub instead of a version range on PyPI. This will allow Nightly users to install all official plugins by running ``pip install -e ".[full]"``.
    - [Bugfix] Start MongoDB when running migrations, because a new data migration fails if MongoDB is not running
regisb added a commit to overhangio/tutor that referenced this issue Jun 6, 2022
- 💥 [Feature] Upgrade to Nutmeg: (by @regisb)
    - 💥 [Feature] Persistent grades are now enabled by default.
    - [Bugfix] Remove edX references from bulk emails ([issue](openedx/wg-build-test-release#100)).
    - [Improvement] For Tutor Nightly (and only Nightly), official plugins are now installed from their nightly branches on GitHub instead of a version range on PyPI. This will allow Nightly users to install all official plugins by running ``pip install -e ".[full]"``.
    - [Bugfix] Start MongoDB when running migrations, because a new data migration fails if MongoDB is not running
regisb added a commit to overhangio/tutor that referenced this issue Jun 6, 2022
- 💥 [Feature] Upgrade to Nutmeg: (by @regisb)
    - 💥 [Feature] Persistent grades are now enabled by default.
    - [Bugfix] Remove edX references from bulk emails ([issue](openedx/wg-build-test-release#100)).
    - [Improvement] For Tutor Nightly (and only Nightly), official plugins are now installed from their nightly branches on GitHub instead of a version range on PyPI. This will allow Nightly users to install all official plugins by running ``pip install -e ".[full]"``.
    - [Bugfix] Start MongoDB when running migrations, because a new data migration fails if MongoDB is not running
regisb added a commit to overhangio/tutor that referenced this issue Jun 6, 2022
- 💥 [Feature] Upgrade to Nutmeg: (by @regisb)
    - 💥 [Feature] Persistent grades are now enabled by default.
    - [Bugfix] Remove edX references from bulk emails ([issue](openedx/wg-build-test-release#100)).
    - [Improvement] For Tutor Nightly (and only Nightly), official plugins are now installed from their nightly branches on GitHub instead of a version range on PyPI. This will allow Nightly users to install all official plugins by running ``pip install -e ".[full]"``.
    - [Bugfix] Start MongoDB when running migrations, because a new data migration fails if MongoDB is not running
regisb added a commit to overhangio/tutor that referenced this issue Jun 6, 2022
- 💥 [Feature] Upgrade to Nutmeg: (by @regisb)
    - 💥 [Feature] Persistent grades are now enabled by default.
    - [Bugfix] Remove edX references from bulk emails ([issue](openedx/wg-build-test-release#100)).
    - [Improvement] For Tutor Nightly (and only Nightly), official plugins are now installed from their nightly branches on GitHub instead of a version range on PyPI. This will allow Nightly users to install all official plugins by running ``pip install -e ".[full]"``.
    - [Bugfix] Start MongoDB when running migrations, because a new data migration fails if MongoDB is not running
regisb added a commit to overhangio/tutor that referenced this issue Jun 6, 2022
- 💥 [Feature] Upgrade to Nutmeg: (by @regisb)
    - 💥 [Feature] Persistent grades are now enabled by default.
    - [Bugfix] Remove edX references from bulk emails ([issue](openedx/wg-build-test-release#100)).
    - [Improvement] For Tutor Nightly (and only Nightly), official plugins are now installed from their nightly branches on GitHub instead of a version range on PyPI. This will allow Nightly users to install all official plugins by running ``pip install -e ".[full]"``.
    - [Bugfix] Start MongoDB when running migrations, because a new data migration fails if MongoDB is not running
regisb added a commit to overhangio/tutor that referenced this issue Jun 7, 2022
- 💥 [Feature] Upgrade to Nutmeg: (by @regisb)
    - 💥 [Feature] Persistent grades are now enabled by default.
    - [Bugfix] Remove edX references from bulk emails ([issue](openedx/wg-build-test-release#100)).
    - [Improvement] For Tutor Nightly (and only Nightly), official plugins are now installed from their nightly branches on GitHub instead of a version range on PyPI. This will allow Nightly users to install all official plugins by running ``pip install -e ".[full]"``.
    - [Bugfix] Start MongoDB when running migrations, because a new data migration fails if MongoDB is not running
regisb added a commit to overhangio/tutor that referenced this issue Jun 9, 2022
- 💥 [Feature] Upgrade to Nutmeg: (by @regisb)
    - 💥 [Feature] Persistent grades are now enabled by default.
    - [Bugfix] Remove edX references from bulk emails ([issue](openedx/wg-build-test-release#100)).
    - [Improvement] For Tutor Nightly (and only Nightly), official plugins are now installed from their nightly branches on GitHub instead of a version range on PyPI. This will allow Nightly users to install all official plugins by running ``pip install -e ".[full]"``.
    - [Bugfix] Start MongoDB when running migrations, because a new data migration fails if MongoDB is not running
regisb added a commit to overhangio/tutor that referenced this issue Jun 9, 2022
- 💥 [Feature] Upgrade to Nutmeg: (by @regisb)
    - 💥 [Feature] Persistent grades are now enabled by default.
    - [Bugfix] Remove edX references from bulk emails ([issue](openedx/wg-build-test-release#100)).
    - [Improvement] For Tutor Nightly (and only Nightly), official plugins are now installed from their nightly branches on GitHub instead of a version range on PyPI. This will allow Nightly users to install all official plugins by running ``pip install -e ".[full]"``.
    - [Bugfix] Start MongoDB when running migrations, because a new data migration fails if MongoDB is not running
regisb added a commit to overhangio/tutor that referenced this issue Jun 9, 2022
- 💥 [Feature] Upgrade to Nutmeg: (by @regisb)
    - 💥 [Feature] Persistent grades are now enabled by default.
    - [Bugfix] Remove edX references from bulk emails ([issue](openedx/wg-build-test-release#100)).
    - [Improvement] For Tutor Nightly (and only Nightly), official plugins are now installed from their nightly branches on GitHub instead of a version range on PyPI. This will allow Nightly users to install all official plugins by running ``pip install -e ".[full]"``.
    - [Bugfix] Start MongoDB when running migrations, because a new data migration fails if MongoDB is not running
regisb added a commit to overhangio/tutor that referenced this issue Jun 9, 2022
- 💥 [Feature] Upgrade to Nutmeg: (by @regisb)
    - 💥 [Feature] Persistent grades are now enabled by default.
    - [Bugfix] Remove edX references from bulk emails ([issue](openedx/wg-build-test-release#100)).
    - [Improvement] For Tutor Nightly (and only Nightly), official plugins are now installed from their nightly branches on GitHub instead of a version range on PyPI. This will allow Nightly users to install all official plugins by running ``pip install -e ".[full]"``.
    - [Bugfix] Start MongoDB when running migrations, because a new data migration fails if MongoDB is not running
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Report of or fix for something that isn't working as intended
Projects
Development

Successfully merging a pull request may close this issue.

6 participants