Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update our browserslist config per "Best Practices" #16

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

bradenmacdonald
Copy link

@bradenmacdonald bradenmacdonald commented Nov 28, 2024

Our browserslist config is currently not following the Best Practices that the browserslist project recommends.

In particular, they say:

Don’t remove browsers just because you don’t know them. Opera Mini has 100 million users in Africa and it is more popular in the global market than Microsoft Edge. Chinese QQ Browsers has more market share than Firefox and desktop Safari combined.

Here is the list of supported browsers (from npm run supported), before and after this change:

 and_chr 131
 and_ff 132
+and_qq 14.9
+and_uc 15.5
+android 131
 chrome 131
 chrome 130
+chrome 129
+chrome 128
+chrome 127
+chrome 126
+chrome 125
+chrome 124
+chrome 109
 edge 131
 edge 130
+edge 129
+edge 128
 firefox 132
 firefox 131
+firefox 130
+firefox 129
+firefox 115
 ios_saf 18.1
 ios_saf 18.0
 ios_saf 17.6-17.7
 ios_saf 17.5
 ios_saf 17.4
 ios_saf 17.3
 ios_saf 17.2
 ios_saf 17.1
 ios_saf 17.0
 ios_saf 16.6-16.7
 ios_saf 16.5
 ios_saf 16.4
 ios_saf 16.3
 ios_saf 16.2
 ios_saf 16.1
 ios_saf 16.0
+ios_saf 15.6-15.8
+kaios 3.0-3.1
+kaios 2.5
+op_mini all
+op_mob 80
+opera 114
+opera 113
+opera 112
 safari 18.1
 safari 18.0
 safari 17.6
 safari 17.5
 safari 17.4
 safari 17.3
 safari 17.2
 safari 17.1
 safari 17.0
+safari 16.6
+safari 15.6
+samsung 26
+samsung 25

I don't have a strong opinion on this change, but I do think it makes sense to follow the best practices if there's little or no cost to doing so.

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Nov 28, 2024
@openedx-webhooks
Copy link

Thanks for the pull request, @bradenmacdonald!

What's next?

Please work through the following steps to get your changes ready for engineering review:

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.

🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads

🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

🔘 Let us know that your PR is ready for review:

Who will review my changes?

This repository is currently unmaintained.

To get help with finding a technical reviewer, tag the community contributions project manager for this PR in a comment and let them know that your changes are ready for review:

  1. On the right-hand side of the PR, find the Contributions project, click the caret in the top right corner to expand it, and check the "Primary PM" field for the name of your PM.
  2. Find their GitHub handle here.

Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
open-source-contribution PR author is not from Axim or 2U
Projects
Status: Ready for Review
Development

Successfully merging this pull request may close these issues.

2 participants