Skip to content
This repository has been archived by the owner on May 2, 2024. It is now read-only.

fix: pass pytest cms ProctoringExamSettingsGetTests #91

Closed
4 tasks done
Carlos-Muniz opened this issue Sep 14, 2022 · 3 comments
Closed
4 tasks done

fix: pass pytest cms ProctoringExamSettingsGetTests #91

Carlos-Muniz opened this issue Sep 14, 2022 · 3 comments
Assignees

Comments

@Carlos-Muniz
Copy link

Carlos-Muniz commented Sep 14, 2022

As part of #36, several tests have been discovered that are not passing in tutor, but passing in devstack. The following tests may not be run by tutor, or may be failing in tutor.

cms/djangoapps/contentstore/rest_api/v1/tests/test_views.py::ProctoringExamSettingsGetTests::

  • test_providers_with_disabled_lti
  • test_providers_with_enabled_lti
  • test_200_for_lti_provider
  • test_400_for_disabled_lti

For more information about the tests that passed, failed, skipped, or never ran, see the spreadsheet with all the tests.

@Carlos-Muniz
Copy link
Author

Carlos-Muniz commented Nov 17, 2022

Tests ran in lms bash via tutor dev run lms bash all pass.

cms/djangoapps/contentstore/rest_api/v1/tests/test_views.py::ProctoringExamSettingsGetTests::test_200_cour
se_instructor PASSED [ 14%]
cms/djangoapps/contentstore/rest_api/v1/tests/test_views.py::ProctoringExamSettingsGetTests::test_200_glob
al_staff PASSED [ 28%]
cms/djangoapps/contentstore/rest_api/v1/tests/test_views.py::ProctoringExamSettingsGetTests::test_403_if_i
nstructor_in_another_course PASSED [ 42%]
cms/djangoapps/contentstore/rest_api/v1/tests/test_views.py::ProctoringExamSettingsGetTests::test_403_if_s
tudent PASSED [ 57%]
cms/djangoapps/contentstore/rest_api/v1/tests/test_views.py::ProctoringExamSettingsGetTests::test_404_no_c
ourse_module PASSED [ 71%]
cms/djangoapps/contentstore/rest_api/v1/tests/test_views.py::ProctoringExamSettingsGetTests::test_provider
s_with_disabled_lti PASSED [ 85%]
cms/djangoapps/contentstore/rest_api/v1/tests/test_views.py::ProctoringExamSettingsGetTests::test_provider
s_with_enabled_lti PASSED [100%]

This is not the case when ran in cms bash via tutor dev run cms bash.
This is because settings.ROOT_URLCONF = lms.urls, even when ran in cms bash.
This is related to https://github.com/overhangio/2u-tutor-adoption/issues/48

@Carlos-Muniz
Copy link
Author

Closing this ticket because it is no longer needed and is a symptom of an issue documented in another ticket.

@Carlos-Muniz Carlos-Muniz self-assigned this Dec 13, 2022
@Carlos-Muniz Carlos-Muniz moved this to To Do - Backlog in Axim Engineering Tasks Dec 13, 2022
@Carlos-Muniz Carlos-Muniz moved this from To Do - Backlog to Done in Axim Engineering Tasks Dec 13, 2022
@Carlos-Muniz
Copy link
Author

This test does pass in tutor. See #155 for more details.

@Carlos-Muniz Carlos-Muniz closed this as not planned Won't fix, can't repro, duplicate, stale Jan 9, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant