Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

test: Remove support for Node 18 #206

Closed
wants to merge 1 commit into from

Conversation

BilalQamar95
Copy link
Contributor

Description

Completed upgrade to Node 20 by removing the Node 18 CI check and using .nvmrc for version to use.

See the tracking issue for further information.

@BilalQamar95 BilalQamar95 self-assigned this Sep 9, 2024
Copy link

codecov bot commented Sep 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 58.22%. Comparing base (db01cde) to head (17b8204).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #206   +/-   ##
=======================================
  Coverage   58.22%   58.22%           
=======================================
  Files          25       25           
  Lines         395      395           
  Branches       66       66           
=======================================
  Hits          230      230           
  Misses        149      149           
  Partials       16       16           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 10772705447

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 55.473%

Totals Coverage Status
Change from base Build 10741783659: 0.0%
Covered Lines: 168
Relevant Lines: 305

💛 - Coveralls

@BilalQamar95 BilalQamar95 mentioned this pull request Sep 11, 2024
@kdmccormick
Copy link
Contributor

We are closing this pull request because Program Console is deprecated. If you work with 2U and you still want to make this change, you could propose it on 2U's fork of Program Console, but the contribution will not be part of the Open edX project.

@kdmccormick kdmccormick deleted the bilalqamar95/node20-upgrade-3 branch September 11, 2024 14:22
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants