This repository has been archived by the owner on Nov 4, 2024. It is now read-only.
temp: add django42 GHA ahead of actual changes #4026
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
christopappas
commented
Sep 6, 2023
| @@ -21,6 +21,15 @@ jobs: | |||
| - django-env: django32 | |||
| testname: acceptance-python | |||
| targets: PYTHON_ENV=py38 requirements.js clean_static static acceptance | |||
| - django-env: django42 | |||
There was a problem hiding this comment.
this adds the actual job runners. and specifies DJANGO_ENV to use
christopappas
commented
Sep 6, 2023
| @@ -1,6 +1,6 @@ | |||
| [tox] | |||
| skipsdist=True | |||
| envlist = py38-django32-{static,pylint,tests,theme_static,check_keywords},py38-{isort,pycodestyle,extract_translations,dummy_translations,compile_translations, detect_changed_translations,validate_translations},docs | |||
| envlist = py38-django32-{static,pylint,tests,theme_static,check_keywords},py38-{isort,pycodestyle,extract_translations,dummy_translations,compile_translations, detect_changed_translations,validate_translations},py38-django42-{static,pylint,tests,theme_static,check_keywords},docs | |||
There was a problem hiding this comment.
this adds an env in the envlist for py38-django42, which is required to run tests
christopappas
commented
Sep 6, 2023
| @@ -48,6 +48,7 @@ setenv = | |||
| deps = | |||
| -r{toxinidir}/requirements/test.txt | |||
| django32: Django>=3.2,<3.3 | |||
| django42: Django==4.2 | |||
There was a problem hiding this comment.
i think this conditionally installs django 4.2 if the DJANGO_ENV is set to django42
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
⛔️ DEPRECATION WARNING
This repository is deprecated and in maintainence-only operation while we work on a replacement, please see this announcement for more information.
Although we have stopped integrating new contributions, we always appreciate security disclosures and patches sent to [email protected]
Anyone internally merging to this repository is expected to release and monitor their changes; if you are not able to do this DO NOT MERGE, please coordinate with someone who can to ensure that the changes are released.
Required Testing
(^ We can remove that manual check once REV-2624 is done and the corresponding e2e test runs again)
Description
Describe what this pull request changes, and why these changes were made. How will these changes affect other people, installations of edx, etc.?
Please include links to any relevant ADRs, design artifacts, and decision documents. Make sure to document the rationale behind significant changes in the repo, per OEP-19, and can be
linked here.
Useful information to include:
Supporting information
Link to other information about the change, such as Jira issues, GitHub issues, or Discourse discussions.
Be sure to check they are publicly readable, or if not, repeat the information here.
Testing instructions
Please provide detailed step-by-step instructions for testing this change; how did YOU test this change?
Other information
Include anything else that will help reviewers and consumers understand the change.