This repository has been archived by the owner on May 6, 2024. It is now read-only.
feat: Switch to Atlas translations in edxapp (attempt 3) #7119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous attempt (#7117) was failing with an error in the call to `paver i18n_compilejs` after the Atlas-specific part of pull_translations, in the part where it runs `npm ci`. I don't have access to the npm log, but I bet it's just that our npm setup wasn't ready yet at this point in the playbook. I think we just need to move this call to after the npm setup. Part of OEP-58 and edx/edx-arch-experiments#548
dianakhuang
approved these changes
Feb 23, 2024
3 tasks
timmc-edx
added a commit
that referenced
this pull request
Feb 23, 2024
…)" This reverts commit 86eec47.
timmc-edx
added a commit
that referenced
this pull request
Feb 23, 2024
4 tasks
timmc-edx
added a commit
that referenced
this pull request
Mar 1, 2024
This is to support OEP-58: https://docs.openedx.org/projects/openedx-proposals/en/latest/architectural-decisions/oep-0058-arch-translations-management.html Changes since the #7119 attempt: - Move to just after main requirements are installed (just for faster feedback during testing, really) - Use already-installed `openedx-atlas` - Use variant-agnostic `EDX_PLATFORM_SETTINGS` rather than `DJANGO_SETTINGS_MODULE` - Use Ansible `environment` field for env vars - Drop `set -eu -o pipefail` since the script is now simple Most importantly, openedx/edx-platform#34306 has since merged, so we don't have to worry about the NPM conflicts we were getting previously.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous attempt (#7117) was failing with an error in the call to
paver i18n_compilejsafter the Atlas-specific part of pull_translations, in the part where it runsnpm ci. I don't have access to the npm log, but I bet it's just that our npm setup wasn't ready yet at this point in the playbook.I think we just need to move this call to after the npm setup.
Part of OEP-58 and edx/edx-arch-experiments#548
Configuration Pull Request
Make sure that the following steps are done before merging: