feat(io-engine): add persistent store transaction API #1791
+155
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsharma-dc
requested review from
tiagolobocastro,
dsavitskiy,
sinhaashish,
Abhinandan-Purkait and
abhilashshetty04
and removed request for
dsavitskiy and
Abhinandan-Purkait
|
bors try |
tryBuild succeeded: |
This change adds API to do Compare-and-Swap operations to the persistent store via io-engine. Signed-off-by: Diwakar Sharma <[email protected]>
dsharma-dc
force-pushed
the
pstor_txn
branch
from
526bdf3 to
5fda89d
Compare
| self.0 | ||
| .txn(Txn::new().when(cmps).and_then(ops_success).or_else(fops)) | ||
| .await | ||
| .context(TxnErr { |
There was a problem hiding this comment.
Do we get an error on the logs which is clear as to what happened?
| ) -> Result<TxnResponse, StoreError> { | ||
| let fops = ops_failure.map_or(vec![], |v| v); | ||
| self.0 | ||
| .txn(Txn::new().when(cmps).and_then(ops_success).or_else(fops)) |
There was a problem hiding this comment.
what is this or_else doing?
| async fn txn_kv<K: StoreKey>( | ||
| &mut self, | ||
| key: &K, | ||
| cmps: Vec<Compare>, |
There was a problem hiding this comment.
Why do we need an array here? Can't we just do .when([cmp]) ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds API to do Compare-and-Swap operations to the persistent store via io-engine.