From ca5da3936b883b2bc48eee04e6f11bc9fe933e6e Mon Sep 17 00:00:00 2001 From: chriswldenyer Date: Tue, 9 Jan 2024 07:09:54 +0000 Subject: [PATCH] fix: code-review comments Signed-off-by: chriswldenyer --- control-plane/agents/src/common/errors.rs | 2 +- tests/bdd/features/volume/capacity_limit/creation.feature | 6 +++--- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/control-plane/agents/src/common/errors.rs b/control-plane/agents/src/common/errors.rs index d01986f71..fae36386b 100644 --- a/control-plane/agents/src/common/errors.rs +++ b/control-plane/agents/src/common/errors.rs @@ -334,7 +334,7 @@ pub enum SvcError { DrainNotAllowedWhenHAisDisabled {}, #[snafu(display("Target switchover is not allowed without HA"))] SwitchoverNotAllowedWhenHAisDisabled {}, - #[snafu(display("The volume would exceed the capacity"))] + #[snafu(display("The volume would exceed the capacity limit"))] VolWouldExceedCapacity {}, } diff --git a/tests/bdd/features/volume/capacity_limit/creation.feature b/tests/bdd/features/volume/capacity_limit/creation.feature index d801fcba6..123c311ef 100644 --- a/tests/bdd/features/volume/capacity_limit/creation.feature +++ b/tests/bdd/features/volume/capacity_limit/creation.feature @@ -3,19 +3,19 @@ Feature: Volume creation capacity limit Background: Given a control plane, Io-Engine instances and a pool - Scenario: attempted creation exceeding the capacity limit + Scenario: attempted volume creation exceeding the capacity limit Given a gRPC request to create a volume When the request includes a capacity limit And the volume creation would result in the capacity limit being exceeded Then volume creation should fail with an out-of-range error - Scenario: attempted creation within the capacity limit + Scenario: attempted volume creation within the capacity limit Given a gRPC request to create a volume When the request includes a capacity limit And the volume creation would not result in the capacity limit being exceeded Then volume creation should succeed - Scenario: attempted creation with no capacity limit + Scenario: attempted volume creation with no capacity limit Given a gRPC request to create a volume When the request does not include a capacity limit Then volume creation should succeed