Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CSV report #182

Merged
merged 8 commits into from
Dec 2, 2024
Merged

CSV report #182

merged 8 commits into from
Dec 2, 2024

Conversation

mccalluc
Copy link
Contributor

@mccalluc mccalluc commented Nov 22, 2024

Not committed to this format for the reports: Just heard that there should be a CSV, but there don't seem to be be any requirements beyond that.

@mccalluc mccalluc marked this pull request as ready for review November 24, 2024 22:10
Copy link
Member

@ekraffmiller ekraffmiller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this looks reasonable, I just have the same comment I have for the report that I think it would be good for the user to see the other inputs (epsilon and weight)

@mccalluc
Copy link
Contributor Author

mccalluc commented Dec 2, 2024

Thanks: Since this is approved, I'll merge it to 173-text-yaml-report, address the comments there, and request re-review.

@mccalluc mccalluc merged commit 4305b14 into 173-text-yaml-report Dec 2, 2024
2 checks passed
@mccalluc mccalluc deleted the 172-csv-report branch December 2, 2024 22:11
mccalluc added a commit that referenced this pull request Dec 3, 2024
* pyyaml dep

* stub reports block

* fix flakey test of weight

* half-way there!

* add confidence and accuracy

* stub inputs

* csv_path

* generate report and drop in tmp

* text report download works

* "please wait"

* test each download

* use original column names in our report

* CSV report (#182)

* use original column names in our report

* flatten util

* checkpoint on CSV report; tests not passing

* csv report works

* add a test

* button grid

* factor out button function

* update test to match

* add epsilon to report

* remove params when we can just get it from self

* Add column info to report
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Complete
Development

Successfully merging this pull request may close these issues.

2 participants