Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set bottom of axis #145

Merged
merged 1 commit into from
Nov 7, 2024
Merged

Set bottom of axis #145

merged 1 commit into from
Nov 7, 2024

Conversation

mccalluc
Copy link
Contributor

@mccalluc mccalluc commented Nov 5, 2024

Time: ~0.25 hours

@mccalluc mccalluc requested a review from ekraffmiller November 5, 2024 20:13
ekraffmiller
ekraffmiller reviewed Nov 7, 2024
View reviewed changes
Copy link
Member

@ekraffmiller ekraffmiller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works as described, but I wonder if it might be good to keep the negative whiskers as a way of teaching how DP works. I think it's an important aspect of it. But that's just my $.02!

@mccalluc
Copy link
Contributor Author

mccalluc commented Nov 7, 2024

I don't think it's useful to keep them. I do think we need to explain the whiskers, and I've filed

to explore other ways of presenting uncertainty, but I don't think the negative axis does this.

@mccalluc mccalluc merged commit 2f08f37 into main Nov 7, 2024
2 checks passed
@mccalluc mccalluc deleted the 143-set-plot-axis branch November 7, 2024 19:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ekraffmiller ekraffmiller ekraffmiller approved these changes

Assignees
No one assigned
Labels
None yet
Projects
DP Wizard
Status: Complete
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Plot should not go below zero
2 participants
@mccalluc @ekraffmiller