Skip to content
This repository has been archived by the owner on Aug 9, 2022. It is now read-only.

Time Range not using Commonly Used Ranges from Kibana Settings #351

Closed
iget-master opened this issue Apr 5, 2021 · 2 comments
Closed

Time Range not using Commonly Used Ranges from Kibana Settings #351

iget-master opened this issue Apr 5, 2021 · 2 comments
Labels
maintenance Improves code quality, but not the product

Comments

@iget-master
Copy link

Currently, the time_range component uses a constant from report_settings_constants.tsx to feed the commonlyUsedRanges property of EuiSuperDatePicker inside it.

This is not the default behavior across Kibana. The default behavior is to load this from uiSettings service, allowing the user to override the available options.

I'm proposing this change that is not a breaking change but a "fix" that makes this plugin follow the default behavior across Kibana.
This was referenced Apr 5, 2021
Closed
Closed
@iget-master
Copy link
Author

Although my PR #352 fixes this, this plugin does not support relative dates (see #353). 😞

@zhongnansu zhongnansu added the maintenance Improves code quality, but not the product label Apr 21, 2021
@zhongnansu zhongnansu mentioned this issue May 13, 2021
Open
@zhongnansu
Copy link
Member

This issue has been moved to opensearch-project/reporting#41

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
maintenance Improves code quality, but not the product
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@iget-master @zhongnansu