Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cluster tasks do not define resource limits #372

Closed
henrjk opened this issue Jan 6, 2022 · 4 comments
Closed

cluster tasks do not define resource limits #372

henrjk opened this issue Jan 6, 2022 · 4 comments
Assignees
Milestone

Comments

@henrjk
Copy link
Member

henrjk commented Jan 6, 2022

At this time Tekton limits our ability to introduce parameterized resource requests and limits (see PR #196)

For us sometimes typescript builds are failing because of memory issues.

Until there is a good mechanism there should probably be sensible limits defined. In addition this issue can also describe or provide a workaround for those affected.

@henrjk
Copy link
Member Author

henrjk commented Jan 6, 2022

As a workaround is to go to the OpenShift web console. Open the Administration View for your projects cd namespace:

  • Select Pipelines>Tasks on the left which should open the Tasks view.
  • On the Tasks view open tab ClusterTasks and open the task for which you would like to change the resource limits. Copy the YAML to your Clipboard.
  • Go back to the Tasks view and select Create/Task with the action button (top right).
  • Paste the YAML from the Clipboard and clean up status info, give it a good name and make sure to change the kind to Task. Add a resources section as needed. Then Press Create.
  • In your ods.yaml you will have to change the taskRef to adjust for the name change and set kind: Task where is was kind: ClusterTask.

No you can run the task with the new resource limits.

@michaelsauter
Copy link
Member

@henrjk Thanks for opening the issue and providing the workaround. This workaround is also described in general nature in https://github.com/opendevstack/ods-pipeline/blob/master/docs/authoring-tasks.adoc#customizing-how-go-applications-are-built. Maybe we can add this use case there as well?

Maybe to provide some more background on this:

The feature has been requested multiple times in the Tekton project, and there are currently two TEPs concerning this issue:

@gerardcl
Copy link
Member

gerardcl commented Jan 7, 2022

this could be added in the FAQ? shall we create a label to track FAQ additions within GH issues/PRs?

@michaelsauter
Copy link
Member

Closing as this is solved to some degree in #404. As tasks are namespaced, the Helm templates defining them can now be used to modify the resources.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants