Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Helm chart validation error if a commit hash starts with 8 or more numbers #1179

Open
faust2199 opened this issue Nov 27, 2024 · 0 comments · May be fixed by #1180
Open

Helm chart validation error if a commit hash starts with 8 or more numbers #1179

faust2199 opened this issue Nov 27, 2024 · 0 comments · May be fixed by #1180
Labels
bug Something isn't working

Comments

@faust2199
Copy link

Describe the bug
[ Credit goes to @renedupont ] A Helm chart can contain a values.schema.json where data types are validated. The imageTag is supposed to be a string, because it is basically taken from the short commit hash and usually has a letter in it. Sometimes the leading 8 characters of the commit hash are all numbers. With the current implementation, such a special commit hash will cause the validation to fail, because helm interprets it as a number, rather than a string.

To Reproduce
Steps to reproduce the behavior:

  1. Work on a component branch with auto deployment enabled
  2. Generate a commit with the leading 8 characters of the commit hash all numbers
  3. Push the code
  4. See error in Jenkins

Expected behavior
Commit hashes with leading numbers should not abort Jenkins builds.

Screenshots
N/A

Affected version (please complete the following information):

  • OpenShift: 4.x
  • OpenDevStack 4.x

Log Output (ensure to remove any confidential information like tokens, project names, etc.

Error: values don't meet the specifications of the schema(s) in the following chart(s):
random-project:
- global.imageTag: Invalid type. Expected: string, given: integer

Additional context
N/A

@faust2199 faust2199 added the bug Something isn't working label Nov 27, 2024
@faust2199 faust2199 linked a pull request Nov 27, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant