Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uniformization of the front/back Markdown rendering for tables #604

Closed
davidbgk opened this issue Nov 3, 2016 · 3 comments
Closed

Uniformization of the front/back Markdown rendering for tables #604

davidbgk opened this issue Nov 3, 2016 · 3 comments
Assignees
Labels
Milestone

Comments

@davidbgk
Copy link
Member

davidbgk commented Nov 3, 2016

Context

When I add a table to the backend interfance, I want to see it rendered as a table on the frontend, so I can propose a nice visualization of the data.

Possible Implementation

Both implementations rely on CommonMark, the front is generated by Python so check if both libs follow the same version and if tables have to be activated.

@davidbgk
Copy link
Member Author

davidbgk commented Nov 3, 2016

capture d ecran 2016-11-03 a 14 43 49

capture d ecran 2016-11-03 a 14 43 40

capture d ecran 2016-11-03 a 14 43 59

@noirbizarre noirbizarre added this to the 1.1 milestone Jan 19, 2017
@abulte
Copy link
Contributor

abulte commented Jun 14, 2017

@davidbgk apparently CommonMark-py does not support tables readthedocs/commonmark.py#28. It looks like Python-Markdown does though https://pythonhosted.org/Markdown/extensions/tables.html, should we consider switching?

@davidbgk
Copy link
Member Author

@abulte you're right, tables are not part of the CommonMark spec, we should measure if tables are really in use before switching to something else if pertinent. It's biased because the current implementation doesn't encourage the use but anyway we have data so let's use it :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants