From e6b5896c1f73e97b69db6a672a1fe3c118be33ec Mon Sep 17 00:00:00 2001 From: Wen Zhou Date: Wed, 24 Jul 2024 10:38:37 +0200 Subject: [PATCH] api: set manifestUri as deprecated - we do not use this for devFlag in DSCI any more - it was used when we still have odh-manifests repo - if use would set devFlags, it should be done in DSC on component base - keep logic still in code but only set warning on API Signed-off-by: Wen Zhou --- apis/dscinitialization/v1/dscinitialization_types.go | 1 + .../dscinitialization.opendatahub.io_dscinitializations.yaml | 3 ++- .../dscinitialization.opendatahub.io_dscinitializations.yaml | 3 ++- docs/api-overview.md | 2 +- 4 files changed, 6 insertions(+), 3 deletions(-) diff --git a/apis/dscinitialization/v1/dscinitialization_types.go b/apis/dscinitialization/v1/dscinitialization_types.go index 50f758a5df8..07f72065920 100644 --- a/apis/dscinitialization/v1/dscinitialization_types.go +++ b/apis/dscinitialization/v1/dscinitialization_types.go @@ -80,6 +80,7 @@ type Monitoring struct { // DevFlags defines list of fields that can be used by developers to test customizations. This is not recommended // to be used in production environment. type DevFlags struct { + // ## DEPRECATED ## : ManifestsUri set on DSCI is not maintained. // Custom manifests uri for odh-manifests // +optional ManifestsUri string `json:"manifestsUri,omitempty"` diff --git a/bundle/manifests/dscinitialization.opendatahub.io_dscinitializations.yaml b/bundle/manifests/dscinitialization.opendatahub.io_dscinitializations.yaml index c91bac9ea2a..abbfc10b858 100644 --- a/bundle/manifests/dscinitialization.opendatahub.io_dscinitializations.yaml +++ b/bundle/manifests/dscinitialization.opendatahub.io_dscinitializations.yaml @@ -77,7 +77,8 @@ spec: - default type: string manifestsUri: - description: Custom manifests uri for odh-manifests + description: '## DEPRECATED ## : ManifestsUri set on DSCI is not + maintained. Custom manifests uri for odh-manifests' type: string type: object monitoring: diff --git a/config/crd/bases/dscinitialization.opendatahub.io_dscinitializations.yaml b/config/crd/bases/dscinitialization.opendatahub.io_dscinitializations.yaml index dd381696bb1..c0272fbd869 100644 --- a/config/crd/bases/dscinitialization.opendatahub.io_dscinitializations.yaml +++ b/config/crd/bases/dscinitialization.opendatahub.io_dscinitializations.yaml @@ -77,7 +77,8 @@ spec: - default type: string manifestsUri: - description: Custom manifests uri for odh-manifests + description: '## DEPRECATED ## : ManifestsUri set on DSCI is not + maintained. Custom manifests uri for odh-manifests' type: string type: object monitoring: diff --git a/docs/api-overview.md b/docs/api-overview.md index 3c963f15088..50d8f27798d 100644 --- a/docs/api-overview.md +++ b/docs/api-overview.md @@ -668,7 +668,7 @@ _Appears in:_ | Field | Description | Default | Validation | | --- | --- | --- | --- | -| `manifestsUri` _string_ | Custom manifests uri for odh-manifests | | | +| `manifestsUri` _string_ | ## DEPRECATED ## : ManifestsUri set on DSCI is not maintained.
Custom manifests uri for odh-manifests | | | | `logmode` _string_ | | production | Enum: [devel development prod production default]
|