From e394746f2d8c46566c6ea92e7b20556b0c86d587 Mon Sep 17 00:00:00 2001 From: Jiri Danek Date: Thu, 24 Oct 2024 09:37:39 +0200 Subject: [PATCH] NO-JIRA: temporarily comment out proper host name validation in route CRD since our test values we use are not valid --- .../config/crd/external/route.openshift.io_routes.yaml | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/components/odh-notebook-controller/config/crd/external/route.openshift.io_routes.yaml b/components/odh-notebook-controller/config/crd/external/route.openshift.io_routes.yaml index f291140a8e3..157a0a04461 100644 --- a/components/odh-notebook-controller/config/crd/external/route.openshift.io_routes.yaml +++ b/components/odh-notebook-controller/config/crd/external/route.openshift.io_routes.yaml @@ -103,7 +103,8 @@ spec: host: description: host is an alias/DNS that points to the service. Optional. If not specified a route name will typically be automatically chosen. Must follow DNS952 subdomain conventions. maxLength: 253 - pattern: ^([a-zA-Z0-9]|[a-zA-Z0-9][a-zA-Z0-9\-]{0,61}[a-zA-Z0-9])(\.([a-zA-Z0-9]|[a-zA-Z0-9][a-zA-Z0-9\-]{0,61}[a-zA-Z0-9]))*$ + # TODO: comment this out, our test values don't pass this validation + # pattern: ^([a-zA-Z0-9]|[a-zA-Z0-9][a-zA-Z0-9\-]{0,61}[a-zA-Z0-9])(\.([a-zA-Z0-9]|[a-zA-Z0-9][a-zA-Z0-9\-]{0,61}[a-zA-Z0-9]))*$ type: string path: description: path that the router watches for, to route traffic for to the service. Optional