Beta #462

nospam2000 · 2019-09-08T10:23:44Z

ESP32 related fixes

to work with newer compilers/platforms

dirkmueller · 2019-09-08T19:02:25Z

airrohr-firmware/airrohr-firmware.ino

-			now = time(nullptr);
+#endif
+#if defined(ESP32)
+		if (now > 17897*24*60*60) { // later than 2019/01/01:00:00:00


doesn't that mean that sntp_time_is_set should not be true?

I'm not sure if I understood your questions correctly.
sntp_time_is_set is initialized with false and only set in the callback time_is_set().
When the callback is called in the first try with "ntp.org", the second part (the change from line 4247 to 4252) will never be reached because the function returns.

Right, I agree with your assessment, sorry, didn't read the code closely. I wonder if we can remove all of the ESP conditionals in the code and use both code paths the same way?

Yes, in this specific case the ESP32 path will work for both. The error checking of the ESP8266 is more strict. The fallback in the ESP32 case to use the local router will not be triggered if the RTC has a date after 2019-01-01 and this will happen on a reboot.

That means:

when ntp.org cannot be reached on the first boot it will fallback to the local router

on the second boot the RTC will already have a valid date and don't do a fallback to the local router. /edit: this means the time will not by synchronized any longer and start to drift

To solve that, I would remove the fallback and replace it by the following solution:
Set multiple servers with one call:

ntp.org

the ntp server(s) announced by dhcp

the local router (actually this shall not be necessary because in many cases this is already covered by 2.)

roughly the code would be the following, but I need to check how to mix dhcp and fixed servers:

sntp_servermode_dhcp(1); sntp_setservername(0, "pool.ntp.org"); sntp_setserver(1, WiFi.gatewayIP());

I would try local first before going to the internet.. I implemented router/pool in my pr that I just opened.

Searching for ntp information in dhcp does sound like a good idea though.

dirkmueller · 2019-09-08T19:04:49Z

airrohr-firmware/airrohr-firmware.ino

-			now = time(nullptr);
+#endif
+#if defined(ESP32)
+		if (now > 17897*24*60*60) { // later than 2019/01/01:00:00:00


why is sntp_time_is_set now only used for ESP8266?

because settimeofday_cb() is not available for ESP32. The examples are using sntp_set_time_sync_notification_cb() but this is not yet available in the newest esp32platform delivered with platformio.

/edit: see also https://github.com/espressif/esp-idf/tree/master/examples/protocols/sntp

Agreed, thanks

bool and integer values were quoted

dirkmueller · 2019-09-09T06:32:12Z

@nospam2000 hah, we were looking at the same problem! I opened #463 for this, it reduces the code bloat a bit as well.

nospam2000 · 2019-09-09T06:36:35Z

we were looking at the same problem!

@dirkmueller how shall we synchronize to avoid duplicate work? Shall we use github issues or the ESP32 chat on luftdaten.info?

dirkmueller · 2019-09-09T07:44:35Z

@nospam2000 yes, we should coordinate. can you point me to the place where to find information about this "chat" on luftdaten.info ?

nospam2000 · 2019-09-09T08:06:44Z

I was invited to the chat by (martin ät luftdaten Punkt info), but I think I can also invite you, if you give me your email address. My address is (nospam2000 ät gmx Punkt de).

using 'lib_ldf_mode = off' because ldf doesn't work correctly for #ifdef'ed includes added config for ESP32 using newest possible ESPSoftwareSerial

and why which variant is needed

dirkmueller · 2019-09-09T11:43:05Z

airrohr-firmware/platformio.ini

 extra_scripts = platformio_script.py
 # This release is reflecting the Arduino Core 2.4.2 release
 # When the requirement for Arduino Core is raised, this
 # needs to be adjusted to the matching version from
 # https://github.com/platformio/platform-espressif8266/releases
-platform_version = [email protected]
+;platform_version = [email protected]
+platform_version = [email protected] ; using Arduino core 2.5.2


please update the comment above - but we can't upgrade to newer arduino core until OTA problem is solved.

already reverted. I have to switch back and forth all the time...

I'm not sure about using which SoftwareSerial variant and version.

What OTA problem?

firmware size>512kB cannot be flashed using OTA:
4 MB Flash 3MB SPIFFS, 512 kB running firmware, 512kB new firmware

by the way: what is the real use of mDNS? Removing it would free some flash and the old version is pretty buggy

I often use it to quickly see the current PM value of my own sensor.

mDNS assigns a name to the node, but also adverttises the services running on the node (e.g. webserver, even the Arduino OTA port if you have local OTA enabled). On Android you can see this with https://play.google.com/store/apps/details?id=com.druk.servicebrowser for example, on linux you can see local services with avahi-discover,

@nospam2000 the name can be discovered in the initial setup step where you connect to it in ap mode. Also I thought you can configure it..

mDNS is used to discover available dust sensors with the firmware flashing tool (https://github.com/opendata-stuttgart/airrohr-firmware-flasher). So usersdon't need to know how to look up the IP address (this project is also for users without much IT knowlegde).
DNSServer is needed for the "login" feature while setting up the sensor. Most OSes send a DNS request for special host names to test internet connectivity. These requests need to be answered.

The description of the firmware flasher says "connect the ESP8266 with a USB cable to your computer (micro-USB)". Can it really also be used for OTA flashing as a local OTA update? Actually that is what I was looking for because the USB upload is a pain.

Not at the moment. Maybe we can implement something similar with the update version @dirkmueller is working on (load new firmware to SPIFFS, update actual firmware to a small binary that will then only copy the new version from SPIFFS to flash)

which is used on the Travis CI server

to make Travis CI build work

nospam2000 · 2019-09-09T13:31:20Z

The build of the ESP32 target didn't succeed, probably because PlatformIO is too old.
Is it possible to switch to a newer PlatformIO version when the esp8266 platform version is now fixed at 1.8.0?

dirkmueller · 2019-09-09T14:10:06Z

Yes, we can remove the cap on platformio to go with a newer version

adde support for the heltec_wifi_lora_32_V2 board

to swap the serial and i2c port

ricki-z · 2019-09-11T09:34:28Z

@nospam2000 could you please rebase your commit? There were some changes by an earlier commit that have some conflicts with your changes.

removed unneeded defines

This reverts commit d88f98c.

This reverts commit bfb2a96.

This reverts commit 945ce7e.

This reverts commit 1339700.

This reverts commit e9516bc.

…software into beta

nospam2000 · 2019-09-11T13:16:58Z

Yes I already rebased, but the original beta branch and therefore now also my branch doesn't compile any longer with ESP32 with the following error (for every use of the debug functions):

Compiling .pio/build/heltec_wifi_lora_32_V2/src/airrohr-firmware.ino.cpp.o
airrohr-firmware.ino: In function 'String SDS_version_date()':
airrohr-firmware.ino:848:84: error: no matching function for call to 'debug_outln_verbose(const char*, const char*)'
  debug_outln_verbose(FPSTR(DBG_TXT_END_READING), FPSTR(DBG_TXT_SDS011_VERSION_DATE));
                                                                                    ^
airrohr-firmware.ino:619:13: note: candidate: void debug_outln_verbose(const __FlashStringHelper*)
 static void debug_outln_verbose(const __FlashStringHelper* text) {
             ^
airrohr-firmware.ino:619:13: note:   candidate expects 1 argument, 2 provided
airrohr-firmware.ino:629:13: note: candidate: void debug_outln_verbose(const __FlashStringHelper*, const String&)
 static void debug_outln_verbose(const __FlashStringHelper* text, const String& option) {
             ^
airrohr-firmware.ino:629:13: note:   no known conversion for argument 1 from 'const char*' to 'const __FlashStringHelper*'

lib_ldf_mode = chain+ for ESP8266 because 'off' doesn't work with SoftwareSerial lib_ldf_mode = off for ESP32

ricki-z

the upload and monitor ports are not the mentioned on all systems. They are different between OSes and they may even differ between different modules (depending on the used serial-2-usb chipset).
So we should avoid setting this.

nospam2000 · 2019-09-11T13:46:26Z

the upload and monitor ports are not the mentioned on all systems. They are different between OSes

I will remove them.

The main problem is, that platformio has all configuration in one file: site/user specific and compile/linker settings.
At the moment I have to switch back and forth before every check-in to keep that config clear from local settings. Maybe I can use environment variables to overcome this, but I think there is also no #if mechanism in platformio.ini.

nospam2000 · 2019-09-11T15:23:12Z

Yes I already rebased, but the original beta branch and therefore now also my branch doesn't compile any longer with ESP32

The reason is this fix espressif/arduino-esp32#1371

use explicit version of espressif32

disabled ESP32 configs

ricki-z · 2019-09-11T18:07:09Z

By removing 'common includes' like <Adafruit_BMP085.h> the source code can't be compiled with the Arduino IDE.
The directory .vscode should be included in .gitignore.

nospam2000 · 2019-09-11T18:28:19Z

By removing 'common includes' like <Adafruit_BMP085.h> the source code can't be compiled with the Arduino IDE.

I just moved these includes down into a section shared by ESP8266 and ESP32. We should keep the differences between both architectures as small as possible and the external libraries are the same for both. Arduino IDE 1.8.9 compiles it for ESP8266 and also ESP32 (using newest libraries).

The directory .vscode should be included in .gitignore.

The ESP32 can do hardware JTAG debugging. For debugging (without PlatformIO-Plus) this hand-written launch.json file is needed. Actually PlatformIO will overwrite it with its own content, so it has to be write protected or just checked out again.
I tried to keep the content as generic as possible.

ricki-z · 2019-09-11T18:45:03Z

Includes: Okay I have found the second block (ex-ESP32). The source code folding here on Github is sometimes 'suboptimal'.

nospam2000 added 3 commits September 8, 2019 12:19

fixed prototype of loop() and setup()

6afb681

to work with newer compilers/platforms

use existing ESP32 serial port instances

826555e

fixed sntp initialization for ESP32

e9516bc

dirkmueller reviewed Sep 8, 2019

View reviewed changes

nospam2000 added 3 commits September 8, 2019 22:28

fixed reading/write config.json

1339700

bool and integer values were quoted

fixed config.json serialization of ints

945ce7e

fixed serialization of numeric values inf config,json

bfb2a96

nospam2000 added 4 commits September 9, 2019 13:23

removed unnecessary .as() and typeof() to fix compile error

d88f98c

reworked lib dependencies

9fb6f87

using 'lib_ldf_mode = off' because ldf doesn't work correctly for #ifdef'ed includes added config for ESP32 using newest possible ESPSoftwareSerial

back to esp8266 platform 1.8.0

7276094

added comment for build_flags -Wl,T option

87d430e

and why which variant is needed

dirkmueller reviewed Sep 9, 2019

View reviewed changes

nospam2000 added 3 commits September 9, 2019 14:51

exclude ESP32 targets from automatic builds

94a20af

removed 'default_envs' because not supported by PIO Core v3.6.7

97d45ff

which is used on the Travis CI server

commented esp32 target

063615a

to make Travis CI build work

nospam2000 added 8 commits September 10, 2019 14:13

uncommented esp32 target

8ecb0af

ESP32 IO mapping for Lolin D32 Pro board

d4d2988

fixed compile error

13c14a3

restructured pin assignments

ad3031e

adde support for the heltec_wifi_lora_32_V2 board

fixed define for ESP32 boards

8a4c56d

to swap the serial and i2c port

reactivated code for OLED reset

d3a8672

excluded .pio dir

05f2cc2

fixed merge errors

3b9a827

nospam2000 added 6 commits September 10, 2019 14:40

commented out ESP32 targets to make Travis work

44bedf2

fixed merge problems

485d6f7

enabled ESP32 again

b24bc00

debugger configuration, adapt to your needs

2cab340

refinement of ESP32 board definitions

2d165c9

added comment for SoftwareSerial

6b51740

nospam2000 added 7 commits September 11, 2019 12:14

added upload+monitor port to nodemcuv2

3e3f202

removed unneeded defines

Revert "removed unnecessary .as() and typeof() to fix compile error"

1ec6f80

This reverts commit d88f98c.

Revert "fixed serialization of numeric values inf config,json"

131068a

This reverts commit bfb2a96.

Revert "fixed config.json serialization of ints"

ed3b909

This reverts commit 945ce7e.

Revert "fixed reading/write config.json"

bc03758

This reverts commit 1339700.

Revert "fixed sntp initialization for ESP32"

cfc8b01

This reverts commit e9516bc.

Merge branch 'beta' of https://github.com/opendata-stuttgart/sensors-…

e9053db

…software into beta

nospam2000 added 3 commits September 11, 2019 15:28

moved serialGPS.begin before powerOnTestSensors()

e1c680b

fixed I2C pin definition

c6105f0

removed SoftwareSerial from refs

d6daad7

lib_ldf_mode = chain+ for ESP8266 because 'off' doesn't work with SoftwareSerial lib_ldf_mode = off for ESP32

ricki-z reviewed Sep 11, 2019

View reviewed changes

nospam2000 added 4 commits September 11, 2019 17:59

extracted common includes

6a11df8

added workaround for ESP32 FPSTR bug

133c0f4

use explicit version of SoftwareSerial

ba85a83

use explicit version of espressif32

removed upload settings

9ac3145

disabled ESP32 configs

renamed #define from JTAG_DEBUGGER to USING_JTAG_DEBUGGER_PINS

3d04417

ricki-z merged commit 8149968 into opendata-stuttgart:beta Sep 11, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Beta #462

Beta #462

nospam2000 commented Sep 8, 2019

dirkmueller Sep 8, 2019

nospam2000 Sep 8, 2019

dirkmueller Sep 9, 2019

nospam2000 Sep 9, 2019 •

edited

Loading

dirkmueller Sep 9, 2019

dirkmueller Sep 8, 2019

nospam2000 Sep 8, 2019 •

edited

Loading

dirkmueller Sep 9, 2019

dirkmueller commented Sep 9, 2019

nospam2000 commented Sep 9, 2019

dirkmueller commented Sep 9, 2019

nospam2000 commented Sep 9, 2019

dirkmueller Sep 9, 2019

nospam2000 Sep 9, 2019

bertrik Sep 9, 2019

nospam2000 Sep 9, 2019

nospam2000 Sep 9, 2019

bertrik Sep 9, 2019

dirkmueller Sep 9, 2019

ricki-z Sep 10, 2019

nospam2000 Sep 10, 2019

ricki-z Sep 10, 2019

nospam2000 commented Sep 9, 2019

dirkmueller commented Sep 9, 2019

ricki-z commented Sep 11, 2019

nospam2000 commented Sep 11, 2019 •

edited

Loading

ricki-z left a comment

nospam2000 commented Sep 11, 2019

nospam2000 commented Sep 11, 2019

ricki-z commented Sep 11, 2019

nospam2000 commented Sep 11, 2019

ricki-z commented Sep 11, 2019

Beta #462

Beta #462

Conversation

nospam2000 commented Sep 8, 2019

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

nospam2000 Sep 9, 2019 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

nospam2000 Sep 8, 2019 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

dirkmueller commented Sep 9, 2019

nospam2000 commented Sep 9, 2019

dirkmueller commented Sep 9, 2019

nospam2000 commented Sep 9, 2019

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

nospam2000 commented Sep 9, 2019

dirkmueller commented Sep 9, 2019

ricki-z commented Sep 11, 2019

nospam2000 commented Sep 11, 2019 • edited Loading

ricki-z left a comment

Choose a reason for hiding this comment

nospam2000 commented Sep 11, 2019

nospam2000 commented Sep 11, 2019

ricki-z commented Sep 11, 2019

nospam2000 commented Sep 11, 2019

ricki-z commented Sep 11, 2019

nospam2000 Sep 9, 2019 •

edited

Loading

nospam2000 Sep 8, 2019 •

edited

Loading

nospam2000 commented Sep 11, 2019 •

edited

Loading