Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

recheck the logic of ocitools --host-specific generate #187

Open
haiyanmeng opened this issue Aug 5, 2016 · 3 comments
Open

recheck the logic of ocitools --host-specific generate #187

haiyanmeng opened this issue Aug 5, 2016 · 3 comments

Comments

@haiyanmeng
Copy link
Contributor

The logic of ocitools --host-specific generate should be rechecked and behave as it is supposed to be.
Here are two examples:

  1. if the user runs ocitools --host-specific generate --linux-cpu-shares=512 on a windows machine, the --linux-cpu-shares should be ignored.
  2. if the user run ocitools --host-specific generate --output config.json on a windows machine, the config.json file should not include the linux section.
@haiyanmeng
Copy link
Contributor Author

@wking , I remembered there is an issue relative to this one opened by you. Right?
If there already has one, let me know and I will close this one.

@wking
Copy link
Contributor

wking commented Aug 5, 2016

On Fri, Aug 05, 2016 at 12:29:24PM -0700, hmeng-19 wrote:

@wking , I remembered there is an issue relative to this one opened
by you. Right? If there already has one, let me know and I will
close this one.

Also host-specific (but for validate) is #132. I made a host-specific
generate comment in 1, but this can be about things like that.

@haiyanmeng
Copy link
Contributor Author

@wking , thanks for pointing out.
Then I will leave this issue open and work on a PR to fix the problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants