Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/oci-image-tool: is having empty refs/ a valid image? #15

Closed
philips opened this issue Sep 21, 2016 · 4 comments
Closed

cmd/oci-image-tool: is having empty refs/ a valid image? #15

philips opened this issue Sep 21, 2016 · 4 comments

Comments

@philips
Copy link
Contributor

philips commented Sep 21, 2016

From @runcom on September 9, 2016 8:40

$SUBJECT and basically, is it valid to have stuff under blobs/ not referenced? Can I still package it up and validation is ok given there are no refs/? Should we print a warning (which can be silenced)?

Copied from original issue: opencontainers/image-spec#287

@philips
Copy link
Contributor Author

philips commented Sep 21, 2016

From @wking on September 9, 2016 9:4

On Fri, Sep 09, 2016 at 01:40:15AM -0700, Antonio Murdaca wrote:

$SUBJECT

I think so. At least I don't see any “and there MUST be at least one
ref” language. And if you cared about running images from the layour
that would be “and there MUST be at least one unpackable ref”
language. And then you have to match the oci-layout version with the
media types that were unpackable when it was current (or is validity
in the eye of the validator?)… This is a bowl that I do not want to
fathom ;).

Maybe folks are just using an image-layout to ship some missing blobs.

I don't see any incentive to image-authors to publish ref-less blobs
and then pretend they are runnable, so I don't see a need to get into
the business of restricting refs.

… and basically, is it valid to have stuff under blobs/ not
referenced?

Yes 1.

Should we print a warning?

Warnings for “there are no refs” and “dangling blob sha256-abc…” sound
useful to me. Maybe put the first behind ‘--log-level warn’ and the
second behind ‘--log-level info’ based on how likely I think they are
to be a mistake and how many lines will get printed if they exist ;).

@philips
Copy link
Contributor Author

philips commented Sep 21, 2016

From @vbatts on September 13, 2016 19:20

Both seem valid to me

@philips
Copy link
Contributor Author

philips commented Sep 21, 2016

From @runcom on September 13, 2016 19:25

Alright, can we keep this open so we won't forget about adding some sort of warning/log when this happens

@xiekeyang
Copy link
Contributor

I think it could be closed by opencontainers/image-spec#533

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants