Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

slices.SortFunc's cmp function uses wrong return type #896

Closed
jayzhudev opened this issue Jul 25, 2023 · 2 comments
Closed

slices.SortFunc's cmp function uses wrong return type #896

jayzhudev opened this issue Jul 25, 2023 · 2 comments

Comments

@jayzhudev
Copy link
Contributor

I noticed that the change in #894 uses slices.SortFunc with bool as the cmp function's return type which seems to be inconsistent compared to what I saw in the docs and in the standard library source code.

Both of the following use int as the return type

This change also seems to break support for the latest 3 Go release.

Thank you!

@jayzhudev jayzhudev changed the title slices.SortFunc uses wrong return type slices.SortFunc's cmp function uses wrong return type Jul 25, 2023
@wenovus
Copy link
Collaborator

wenovus commented Jul 25, 2023

Thanks Jay, we have just fixed this here: https://github.com/openconfig/ygot/releases/tag/v0.29.5

@wenovus wenovus closed this as completed Jul 25, 2023
@jayzhudev
Copy link
Contributor Author

Thanks Jay, we have just fixed this here: https://github.com/openconfig/ygot/releases/tag/v0.29.5

That's awesome, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants