You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I noticed that the change in #894 uses slices.SortFunc with bool as the cmp function's return type which seems to be inconsistent compared to what I saw in the docs and in the standard library source code.
I noticed that the change in #894 uses
slices.SortFunc
withbool
as thecmp
function's return type which seems to be inconsistent compared to what I saw in the docs and in the standard library source code.Both of the following use
int
as the return typemaster
branch: https://github.com/golang/go/blob/master/src/slices/sort.go#L28This change also seems to break support for the latest 3 Go release.
Thank you!
The text was updated successfully, but these errors were encountered: