Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarification and use of "system-id" defined differently within isis and lacp modules #1227

Open
osquitun opened this issue Nov 18, 2024 · 2 comments

Comments

@osquitun
Copy link

The "system-id" looks to be defined differently in the isis and lacp modules. Within isis, the system-id seems to only be included within the neighbor adjacency paths so where is the local system-id that may be derived provided to query against for the remote system?

openconfig-isis-types.yang
typedef system-id {
type string {
pattern '[0-9A-Fa-f]{4}.[0-9A-Fa-f]{4}.[0-9A-Fa-f]{4}';
oc-ext:posix-pattern '^[0-9A-Fa-f]{4}.[0-9A-Fa-f]{4}.[0-9A-Fa-f]{4}$';
}
description
"This type defines ISIS system id using pattern, system id looks
like : 0143.0438.AeF0";
}

Similarly, where is the local system-id which was expected in the /system/state information but was only observed within the lacp module. If lacp is not used, where should the mac address based system-id be retrieved from?

openconfig-lacp.yang
leaf system-id {
type oc-yang:mac-address;
description
"MAC address that defines the local system ID for the
aggregate interface";
}

Within lacp the /lacp/interfaces/interface/state identifies the system-id-mac with description of "The MAC address portion of the node's System ID. This is combined with the system priority to construct the 8-octet system-id' but the type only indicates "type: oc-yang:mac-address"
The /lacp/interfaces/interface/members/members/state/system-id description only mentions MAC address for the local system ID for the aggregate interface with "type: oc-yang:mac-address"

Am I overlooking another area of the modules where isis is defined or should the system-id be changed to reflect isis-system-id and include the local value in addition to the neighbor?

Similar with MAC based system-id and should this be presented in the /system/state/ attributes to identify the value for the local device and not just part of lacp?

@osquitun
Copy link
Author

Clarification to the underlying question: What is the expected method to configure the isis protocol?

Cisco and Juniper configuration associate a "net" or "iso" type address when configuring isis from examples on their respective user documentation. The /interfaces/interface/subinterfaces/subinterface defines ipv4 and ipv6 related address configuration but not "iso".

There is a "area-address" of type oc-isis-type:area-address that is consistent with the net/iso address returned in the network-instance .../isis/interfaces/interface/adjacencies/adjacency/state/area-address.

Where is this area-address configured as part of the overall configuration and enabling the isis protocol on an interface?

Cisco:

Device(config)# router isis
Device(config-router)# net 49.0001.0000.0000.000b.00

Device(config-if)# ip address 172.16.1.27 255.255.255.0
Device(config-if)# ip router isis company1

Juniper:

[edit interfaces]
user@R1# set lo0 unit 0 family inet address 192.168.0.1/32
user@R1# set lo0 unit 0 family iso address 49.0002.0192.0168.0001.00

[edit protocols]
user@R1# set isis interface lo0.0

@LimeHat
Copy link

LimeHat commented Dec 1, 2024

Where is this area-address configured as part of the overall configuration and enabling the isis protocol on an interface?

leaf-list net {
type oc-isis-types:net;
description
"ISIS network entity title (NET). The first 8 bits are usually
49 (private AFI), next 16 bits represent area, next 48 bits represent
system id and final 8 bits are set to 0.";
reference
"International Organization for Standardization, Information
technology - Open Systems Interconnection-Network service
Definition - ISO/ IEC 8348:2002.";
}

Not sure if you have any outstanding inquires on your original question, but LACP has nothing to do with IS-IS. Indeed the system-ids in LACP and IS-IS are different and independent from each other.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

No branches or pull requests

2 participants