Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clarify last-reboot-time is updated during a power-on event #1179

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Clarify last-reboot-time is updated during a power-on event #1179

wants to merge 5 commits into from

Conversation

dplore
Copy link
Member

@dplore dplore commented Sep 9, 2024 •
edited
Loading

Fixes #1171

@dplore dplore requested a review from a team as a code owner September 9, 2024 20:35
@OpenConfigBot
Copy link

OpenConfigBot commented Sep 9, 2024 •
edited
Loading

No major YANG version changes in commit 3edd9fd

@dplore dplore added the last-call PR that is in final review before merging. label Sep 10, 2024
s19nal
s19nal approved these changes Sep 10, 2024
View reviewed changes
Copy link

@s19nal s19nal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed at the OC operators meeting, the simplest change to clarify the description defining what this leaf is intended to represent is the least disruptive. Pedantically the leaf name last-reboot-time remains slightly misleading, but that could always be another PR if anyone feels strongly enough about it?

@dplore
Copy link
Member Author

dplore commented Sep 19, 2024 •
edited
Loading

@rgwilton @earies @LimeHat @nandanarista for any comments

@LimeHat
Copy link

LimeHat commented Sep 20, 2024

looks good to me.

@rolandphung
Copy link
Contributor

With last-poweroff-reason and this semantic change to last-reboot-time to be defined to be similar to boot-time, should we consider deprecating last-reboot-reason?

@AnandJyrm
Copy link

@dplore Wouldn't it be better to add a new leaf called boot-time/component-boot-time indicating the boot time of the component? openconfig-system boot-time could indicate the boot-time of active controller card in a modular system or chassis in case of a fixed system.

@earies
Copy link
Contributor

earies commented Sep 20, 2024

Few generic comments/questions

  • Should verbiage/expectations be added around reboots surrounding image upgrades, ZTP re-instantiation, etc.. where such values may not be retained?
  • For POSIX compatible systems, see influence/structure from utmpx - e.g. last command, /var/log/wtmp - are distinct leafs needed vs. a flexible structure, historical events, etc..?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@s19nal s19nal s19nal approved these changes

Assignees
No one assigned
Labels
last-call PR that is in final review before merging. non-breaking
Projects
OC Operator Review
Status: Waiting for author
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Clarification on last-reboot-time, boot-time and up-time
7 participants
@dplore @OpenConfigBot @LimeHat @rolandphung @AnandJyrm @earies @s19nal