Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add attribute for number of available SAs per SC #1420

Merged
merged 1 commit into from
Feb 28, 2022

Conversation

skbarista
Copy link
Contributor

Add attribute for number of available SAs per SC

@rlhui rlhui self-requested a review February 28, 2022 03:38
@rlhui
Copy link
Collaborator

rlhui commented Feb 28, 2022

@skbarista - build failed.

@skbarista skbarista force-pushed the onebitan branch 2 times, most recently from f2ff8e7 to 8138e1c Compare February 28, 2022 05:23
Signed-off-by: Sambath Kumar Balasubramanian <[email protected]>
@skbarista
Copy link
Contributor Author

@rlhui I squashed the commits and build looks fine now.

@JaiOCP
Copy link
Contributor

JaiOCP commented Feb 28, 2022

@skbarista Sarath, can you respond to my query so that I can close the review

@skbarista
Copy link
Contributor Author

@JaiOCP was there a question for me? I did not see a question in the pr conversations.

@JaiOCP
Copy link
Contributor

JaiOCP commented Feb 28, 2022

Are secure association always power of 2?

@skbarista Hi Sambath, Sorry yes it was a question for you. I have left review comments.

.....snippet...
JaiOCP started a review
Pending
inc/saimacsec.h
SAI_MACSEC_MAX_SECURE_ASSOCIATIONS_PER_SC_TWO,
SAI_MACSEC_MAX_SECURE_ASSOCIATIONS_PER_SC_FOUR,
} sai_macsec_max_secure_associations_per_sc_t;

Contributor
@JaiOCP JaiOCP Pending
Are secure association always power of 2?

@skbarista
Copy link
Contributor Author

@JaiOCP I think when I squashed the commit, the comment got lost. Right now the only values for number of secure associations are 2 and 4.

@JaiOCP
Copy link
Contributor

JaiOCP commented Feb 28, 2022

@JaiOCP I think when I squashed the commit, the comment got lost. Right now the only values for number of secure associations are 2 and 4.

Thanks.

Copy link
Contributor

@JaiOCP JaiOCP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Loos good

SAI_MACSEC_MAX_SECURE_ASSOCIATIONS_PER_SC_TWO,
SAI_MACSEC_MAX_SECURE_ASSOCIATIONS_PER_SC_FOUR,
} sai_macsec_max_secure_associations_per_sc_t;

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are secure association always power of 2?

@rlhui rlhui merged commit dff19bc into opencomputeproject:master Feb 28, 2022
Pterosaur pushed a commit to sonic-net/sonic-swss that referenced this pull request May 18, 2022
What I did
Taught MacsecOrch to use the SAI_MACSEC_ATTR_MAX_SECURE_ASSOCIATIONS_PER_SC attribute added in
opencomputeproject/SAI#1420

Why I did it
To support SAI_MACSEC_ATTR_MAX_SECURE_ASSOCIATIONS_PER_SC in MacsecOrch.

How I verified it
The changes have no impact until SAI_MACSEC_ATTR_MAX_SECURE_ASSOCIATIONS_PER_SC is supported by the platform.

Details
Cache the the result of SAI_MACSEC_ATTR_MAX_SECURE_ASSOCIATIONS_PER_SC in MACsecObject.m_max_sa_per_sc.
Set STATE_DB MACSEC_PORT_TABLE's max_sa_per_sc to the value cached in MACsecObject.m_max_sa_per_sc in createMACsecPort.

Signed-off-by: Nathan Wolfe <[email protected]>
preetham-singh pushed a commit to preetham-singh/sonic-swss that referenced this pull request Aug 6, 2022
What I did
Taught MacsecOrch to use the SAI_MACSEC_ATTR_MAX_SECURE_ASSOCIATIONS_PER_SC attribute added in
opencomputeproject/SAI#1420

Why I did it
To support SAI_MACSEC_ATTR_MAX_SECURE_ASSOCIATIONS_PER_SC in MacsecOrch.

How I verified it
The changes have no impact until SAI_MACSEC_ATTR_MAX_SECURE_ASSOCIATIONS_PER_SC is supported by the platform.

Details
Cache the the result of SAI_MACSEC_ATTR_MAX_SECURE_ASSOCIATIONS_PER_SC in MACsecObject.m_max_sa_per_sc.
Set STATE_DB MACSEC_PORT_TABLE's max_sa_per_sc to the value cached in MACsecObject.m_max_sa_per_sc in createMACsecPort.

Signed-off-by: Nathan Wolfe <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants