-
Notifications
You must be signed in to change notification settings - Fork 480
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add attribute for number of available SAs per SC #1420
Conversation
@skbarista - build failed. |
f2ff8e7
to
8138e1c
Compare
Signed-off-by: Sambath Kumar Balasubramanian <[email protected]>
@rlhui I squashed the commits and build looks fine now. |
@skbarista Sarath, can you respond to my query so that I can close the review |
@JaiOCP was there a question for me? I did not see a question in the pr conversations. |
@skbarista Hi Sambath, Sorry yes it was a question for you. I have left review comments. .....snippet... Contributor |
@JaiOCP I think when I squashed the commit, the comment got lost. Right now the only values for number of secure associations are 2 and 4. |
Thanks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Loos good
SAI_MACSEC_MAX_SECURE_ASSOCIATIONS_PER_SC_TWO, | ||
SAI_MACSEC_MAX_SECURE_ASSOCIATIONS_PER_SC_FOUR, | ||
} sai_macsec_max_secure_associations_per_sc_t; | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are secure association always power of 2?
What I did Taught MacsecOrch to use the SAI_MACSEC_ATTR_MAX_SECURE_ASSOCIATIONS_PER_SC attribute added in opencomputeproject/SAI#1420 Why I did it To support SAI_MACSEC_ATTR_MAX_SECURE_ASSOCIATIONS_PER_SC in MacsecOrch. How I verified it The changes have no impact until SAI_MACSEC_ATTR_MAX_SECURE_ASSOCIATIONS_PER_SC is supported by the platform. Details Cache the the result of SAI_MACSEC_ATTR_MAX_SECURE_ASSOCIATIONS_PER_SC in MACsecObject.m_max_sa_per_sc. Set STATE_DB MACSEC_PORT_TABLE's max_sa_per_sc to the value cached in MACsecObject.m_max_sa_per_sc in createMACsecPort. Signed-off-by: Nathan Wolfe <[email protected]>
What I did Taught MacsecOrch to use the SAI_MACSEC_ATTR_MAX_SECURE_ASSOCIATIONS_PER_SC attribute added in opencomputeproject/SAI#1420 Why I did it To support SAI_MACSEC_ATTR_MAX_SECURE_ASSOCIATIONS_PER_SC in MacsecOrch. How I verified it The changes have no impact until SAI_MACSEC_ATTR_MAX_SECURE_ASSOCIATIONS_PER_SC is supported by the platform. Details Cache the the result of SAI_MACSEC_ATTR_MAX_SECURE_ASSOCIATIONS_PER_SC in MACsecObject.m_max_sa_per_sc. Set STATE_DB MACSEC_PORT_TABLE's max_sa_per_sc to the value cached in MACsecObject.m_max_sa_per_sc in createMACsecPort. Signed-off-by: Nathan Wolfe <[email protected]>
Add attribute for number of available SAs per SC