Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for per-vlan traps #1056

Closed
wants to merge 1 commit into from
Closed

Support for per-vlan traps #1056

wants to merge 1 commit into from

Conversation

bandaru-viswanath
Copy link
Contributor

Add an ability for the user to specify a list of traps that are applicable (only) for that vlan. This list is in-addition to the traps that are otherwise generally defined.

@rlhui
Copy link
Collaborator

rlhui commented Mar 26, 2020

What if same object is in both the host trap table and this vlan trap table?

@rck-innovium
Copy link
Contributor

As discussed during the meeting can you summarize the reasons for diverging from the behavior of SAI_HOSTIF_TRAP_ATTR_EXCLUDE_PORT_LIST, i.e. why not have have SAI_HOSTIF_TRAP_ATTR_EXCLUDE_VLAN_LIST?

@rck-innovium
Copy link
Contributor

The key to create the SAI_HOSTIF_TRAP object is currently the SAI_HOSTIF_TRAP_ATTR_TRAP_TYPE. The use case where two VLANs that need different behavior for the same trap will not work as is today.

@rlhui
Copy link
Collaborator

rlhui commented Apr 2, 2020

There's a feedback from Matty in sai meeting - packets going to cpu need to be via hostif_trap channel, it cannot be omitted, even though it is meant to be per-vlan trap. @mattyk , please clarify if any. @bandaru-viswanath should address this first.

@JaiOCP
Copy link
Contributor

JaiOCP commented May 27, 2020

As discussed during the meeting can you summarize the reasons for diverging from the behavior of SAI_HOSTIF_TRAP_ATTR_EXCLUDE_PORT_LIST, i.e. why not have have SAI_HOSTIF_TRAP_ATTR_EXCLUDE_VLAN_LIST?

Would it make sense to have then a common exclude LIST based on a type where TYPE can be PORT/VLAN/RIF ?

@lguohan
Copy link
Collaborator

lguohan commented May 29, 2020

retest this please

@JaiOCP
Copy link
Contributor

JaiOCP commented May 29, 2020 via email

@bandaru-viswanath
Copy link
Contributor Author

Closing this PR as per recommendation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants