Skip to content
This repository has been archived by the owner on Sep 11, 2023. It is now read-only.

Rename time_resolution_minutes to sample_period_minutes to make the code consistent #584

Open
JackKelly opened this issue Jan 26, 2022 · 1 comment · May be fixed by #587
Open

Rename time_resolution_minutes to sample_period_minutes to make the code consistent #584

JackKelly opened this issue Jan 26, 2022 · 1 comment · May be fixed by #587
Labels
enhancement New feature or request good first issue Good for newcomers refactoring

Comments

@JackKelly
Copy link
Member

Detailed Description

model.py uses time_resolution_minutes. Elsewhere in the code this same concept is called sample_period_minutes.

Context

Good to be consistent throughout the code.
@JackKelly JackKelly added enhancement New feature or request refactoring labels Jan 26, 2022
@JackKelly JackKelly moved this to Todo in Nowcasting Jan 26, 2022
@JackKelly JackKelly added the good first issue Good for newcomers label Jan 26, 2022
@RishiKumarRay RishiKumarRay linked a pull request Jan 27, 2022 that will close this issue
Open
@RishiKumarRay
Copy link

@JackKelly can you review the PR for this issue #587

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers refactoring
Projects
No open projects
Nowcasting
Status: Todo
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Rename time_resolution_minutes to sample_period_minutes to make the code consistent
2 participants
@JackKelly @RishiKumarRay