Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix test workflow GitHub Action #88

Closed
jacobbieker opened this issue Mar 11, 2024 · 3 comments
Closed

Fix test workflow GitHub Action #88

jacobbieker opened this issue Mar 11, 2024 · 3 comments
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@jacobbieker
Copy link
Member

Describe the bug

The test GitHub Action workflow is failing on installing PyTorch or PyTorch Geometric.

To Reproduce

Steps to reproduce the behavior:
Look at the Actions tab of the repo, and the failed test runs.

Expected behavior

PyTorch and PyTorch Geometric should be installed successfully so that the tests can run.

Additional context

We also want to keep up with the latest PyTorch Geometic/PyTorch/Python versions.

@jacobbieker jacobbieker added bug Something isn't working good first issue Good for newcomers labels Mar 11, 2024
@aavashsubedi
Copy link
Contributor

Hi, so there's currently no support for 2.0.0/2.1.0 for torch on Python 3.12 and this appears to be the test that's failing. Is it alright to skip these combinations on the workflow.yaml until Torch releases it? pytorch/pytorch#110436 (also nothing here too: https://download.pytorch.org/whl/torch/)

@aavashsubedi
Copy link
Contributor

@jacobbieker #89

@jacobbieker
Copy link
Member Author

Awesome! Thanks for this! Fixed in #89

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants