A class for each system property

[amihaiemil]

We read a few system properties in the aws layer.
Let's create classes for each of them and correct the unit tests, according to this article

[amihaiemil]

@SherifWaly Want to start this? It's quite a lot of changes, but we use PDD.

For starters, I would add interfaces EsEndpoint, Region, AccessKeyId, and SecretKey (these are 4 system properties that are read in the AWS logic). All of these 4 interfaces should extend interface SystemProperty which has the method String read(). In the package com.amihaiemil.charles.aws

What do you think?

[SherifWaly]

@amihaiemil Ok I will try to understand this task and start it.

[amihaiemil]

@SherifWaly Just read that article and add those interfaces -- no need to start using them in the code yet. I'll start with them and you'll see :D

And leave a puzzle in the code, for this task to be continued

[amihaiemil]

@SherifWaly By the way, the build on this project is simply mvn clean install (no checkstyle because it wasn't added from the beginning and now it's a mess... I'll have to fix it someday... see here)

[amihaiemil]

@SherifWaly btw, you are now listed as a contributor here: http://charles.amihaiemil.com

[SherifWaly]

@amihaiemil I'm happy to know that :D Thanks Mihai!