Skip to content
This repository has been archived by the owner on Dec 5, 2020. It is now read-only.

Drop autocomplete for now #164

Closed
amihaiemil opened this issue Dec 24, 2016 · 1 comment
Closed

Drop autocomplete for now #164

amihaiemil opened this issue Dec 24, 2016 · 1 comment

Comments

@amihaiemil
Copy link
Member

amihaiemil commented Dec 24, 2016

Let's drop autocomplete and just use "search-as-you-type", for 2 reasons:

  • it takes a lot of time to implement the completion suggestion in elasticsearch. See here
  • it is very difficult and bug prompt from the front-end's pov. How do you show both autocomplete and search results in a cool manner, without having the user add all sorts of css? There is the problem that the searc results component has to be a child of the input component etc.

We solve this issue by simply having search-as-you-type functionality instead of autocomplete and no actual search results. In the end it will look like a simple widget that the user adds on a page and while he types, results appear right beneath the search field.

In this ticket: drop all the uncalled code related to autocomplete, implemented so far, and remove todos for the now-obsolete puzzles: #157 #158 #159 #160

@amihaiemil
Copy link
Member Author

amihaiemil commented Dec 24, 2016

done 14bf475

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

1 participant