From 52bb22737337d676a8b214ff0650db155b4a3d85 Mon Sep 17 00:00:00 2001 From: amihaiemil Date: Thu, 17 Aug 2017 15:04:54 +0300 Subject: [PATCH] unit tests and puzzle --- .../com/amihaiemil/charles/github/Tweet.java | 2 + .../charles/github/TweetTestCase.java | 80 +++++++++++++++++++ 2 files changed, 82 insertions(+) create mode 100644 src/test/java/com/amihaiemil/charles/github/TweetTestCase.java diff --git a/src/main/java/com/amihaiemil/charles/github/Tweet.java b/src/main/java/com/amihaiemil/charles/github/Tweet.java index d0349b8..9501422 100644 --- a/src/main/java/com/amihaiemil/charles/github/Tweet.java +++ b/src/main/java/com/amihaiemil/charles/github/Tweet.java @@ -36,6 +36,8 @@ * @author Mihai Andronache (amihaiemil@gmail.com) * @version $Id$ * @since 1.0.1 + * @todo #241:30min Pull out the system proerties, same as was done + * in the aws layer, to simplify the unit tests. */ public final class Tweet extends IntermediaryStep { diff --git a/src/test/java/com/amihaiemil/charles/github/TweetTestCase.java b/src/test/java/com/amihaiemil/charles/github/TweetTestCase.java new file mode 100644 index 0000000..e5a2a3f --- /dev/null +++ b/src/test/java/com/amihaiemil/charles/github/TweetTestCase.java @@ -0,0 +1,80 @@ +/** + * Copyright (c) 2016-2017, Mihai Emil Andronache + * All rights reserved. + * Redistribution and use in source and binary forms, with or without + * modification, are permitted provided that the following conditions are met: + * 1)Redistributions of source code must retain the above copyright notice, + * this list of conditions and the following disclaimer. + * 2)Redistributions in binary form must reproduce the above copyright notice, + * this list of conditions and the following disclaimer in the documentation + * and/or other materials provided with the distribution. + * 3)Neither the name of charles-rest nor the names of its + * contributors may be used to endorse or promote products derived from + * this software without specific prior written permission. + * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS IS" + * AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE + * IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE + * ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT HOLDER OR CONTRIBUTORS BE + * LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR + * CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF + * SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS + * INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN + * CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) + * ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE + * POSSIBILITY OF SUCH DAMAGE. + */ +package com.amihaiemil.charles.github; + +import org.junit.Test; +import org.mockito.Mockito; +import org.slf4j.Logger; + +/** + * Unit tests for {@link Tweet} + * @author Mihai Andronache (amihaiemil@gmail.com) + * @version $Id$ + * @since 1.0.1 + */ +public final class TweetTestCase { + + /** + * Tweet will log a message informing the commander that tweeting is off + * and can be enabled via .charles.yml + * @throws Exception If something goes wrong. + */ + @Test + public void logsWhenTweetingIsOff() throws Exception { + final Command com = Mockito.mock(Command.class); + final CachedRepo repo = Mockito.mock(CachedRepo.class); + Mockito.when(repo.charlesYml()).thenReturn(new CharlesYml.Default()); + Mockito.when(com.repo()).thenReturn(repo); + + final Logger logger = Mockito.mock(Logger.class); + + final Step tweet = new Tweet(new Step.Fake(true)); + tweet.perform(com, logger); + Mockito.verify(logger).info("Tweeting is disabled, won't tweet. You can enable tweeting via .charles.yml file."); + } + + /** + * Tweet will log a message informing the commander that tweeting is not possible because some + * mandatory system properties are not set, + * @throws Exception If something goes wrong. + */ + @Test + public void logsWhenSysPropsAreMissing() throws Exception { + final Command com = Mockito.mock(Command.class); + final CachedRepo repo = Mockito.mock(CachedRepo.class); + final CharlesYml yml = Mockito.mock(CharlesYml.class); + Mockito.when(yml.tweet()).thenReturn(true); + Mockito.when(repo.charlesYml()).thenReturn(yml); + Mockito.when(com.repo()).thenReturn(repo); + + final Logger logger = Mockito.mock(Logger.class); + + final Step tweet = new Tweet(new Step.Fake(true)); + tweet.perform(com, logger); + Mockito.verify(logger).warn("One of the 4 tweeter system properties is missing! Cannot tweet!"); + } + +}