-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Keep all translations in OKAPI #576
Comments
From our (OCPL) point of view translations phrases in DB are difficult in maintenance. We would like to be sure what translations are supported based on code not on DB which can be different between nodes and local dev. setups. |
OCDE has all master translations in files, but copies them to the database with each code deployment. So they are both in Git and in the database and always identical everywhere. (The same is done with triggers & stored procedures, and all other static stuff in the database.) |
Got it. I'm interesting if they are any pros of having translations in DB and maintaining it on that way? Why not just read from files? Or maybe it was done because of compatibility with OCPL-code running nodes? |
Probably it's just another way of doing the same thing. OCDE will e.g. join the cache_types table to the translations table on |
OKAPI currently reads translations for country names, language names [with #570] and waypoint types from OC database. But OCPL plans to remove translations from the database, and anyway it's better if OKAPI returns consistent texts for all OC sites (including OCDE sites).
So I suggest to add all these translations to Okapi. If a country or language or wp-type name translation would be completely missing, we could just fall back to the code or type-id, and send email to Okapi developers.
The country and language names can be extracted from Wikipedia.
The text was updated successfully, but these errors were encountered: