Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set isSMB property of SMB treatments uploaded to Nightscout #1280

Closed
cascer1 opened this issue Jul 22, 2019 · 1 comment
Closed

Set isSMB property of SMB treatments uploaded to Nightscout #1280

cascer1 opened this issue Jul 22, 2019 · 1 comment

Comments

@cascer1
Copy link
Contributor

cascer1 commented Jul 22, 2019

Is your feature request related to a problem? Please describe.
To support cleaner rendering code of SMBs in Nightscout, it would be useful to set the isSMB property of SMB treamtents uploaded to nightscout, like AndroidAPS does.

Describe the solution you'd like
Currently, the nightscout code checks for an insulin amount, carb amount, and uploader name when determining whether to render a bolus as SMB. Instead, it could simply check the isSMB property. For this, we need to include this property when uploading SMB treatments to Nightscout.

Additional context

The rendering code change is proposed in nightscout/cgm-remote-monitor#4771

We can remove the first part of the if statement and simply check for isSMB if this feature is implemented in OpenAPS.

@cascer1
Copy link
Contributor Author

cascer1 commented Aug 27, 2019

Closing issue because I realized the stateless design of OpenAPS makes it impossible to reliably determine wether or not a bolus was an SMB after the fact.

@cascer1 cascer1 closed this as completed Aug 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant