Stop Using a Deprecated Docker Client

[RealTYPICAL]

Currently the shiny proxy uses com.spotify:docker-client:jar:8.16.0 which is considered deprecated as of writing https://github.com/spotify/docker-client

Would it be possible to use its canonical replacement found here: https://github.com/docker-java/docker-java

The reason is that the spotify:docker-client has many issues associated with it in regards to the socket hanging when trying to listen for the response. It looks like it's a common problem with older versions of the spotify docker lib.

fabric8io/docker-maven-plugin#344
fabric8io/docker-maven-plugin#981
fabric8io/docker-maven-plugin#552
fabric8io/docker-maven-plugin#862

Some explanations in older issues for other projects indicate that it's related to an interaction between the native socket library, the system, and how it's being used (the spotify docker lib). In TCP HTTP the connection will close/once it has reached the end even if you try to read too much, but the domain socket will not.

Thanks in advance.

[LEDfan]

Hi, thanks for raising this issue. As mentioned in openanalytics/shinyproxy#474 we are looking into replacing the deprecated library for the next release. We have not yet decided which library to use, since we also want to avoid to have rewrite all the code interacting with the docker containers. I'll update this issue once we have replaced the library.

[LEDfan]

Hi, this is now part of the ShinyProxy 3.1.0 we released today. Thank you for opening this issue.