Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Typo in proof #83

Closed
justuswill opened this issue Dec 23, 2018 · 2 comments · Fixed by #207
Closed

Typo in proof #83

justuswill opened this issue Dec 23, 2018 · 2 comments · Fixed by #207

Comments

@justuswill
Copy link

I think in the extra material (Proof for Using Q-Function in Policy Gradient Formula)

spinningup/docs/spinningup/extra_pg_proof2.rst

there is a small typo in the definition of R_t
It should be R(s_t' , a_t', s_t'+1) instead of R(s_t , a_t, s_t+1)
@ghost
Copy link

ghost commented Feb 2, 2020

can i take up this issue ?

@ghost ghost mentioned this issue Feb 2, 2020
Merged
@justuswill
Copy link
Author

Sure

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fixed typo in /docs/spinningup/extra_pg_proof2.rst
1 participant
@justuswill