New realname in .changes makes rpmlint confused.

[zaitor]

osc vc now adds real name to .changes
I have an ø in my name (special Nordic letters are æøå (ÆØÅ)):

+Wed Aug 29 13:06:29 UTC 2018 - Bjørn Lie <[email protected]>
+
+- Dummy entry.
+
 -------------------------------------------------------------------

This leads to the following rpmlint report:

[   25s] RPMLINT report:
[   25s] ===============
[   26s] dconf-devel.x86_64: W: no-version-in-last-changelog
[   26s] dconf.src: W: no-version-in-last-changelog
[   26s] dconf.x86_64: W: no-version-in-last-changelog
[   26s] gsettings-backend-dconf.x86_64: W: no-version-in-last-changelog
[   26s] libdconf1.x86_64: W: no-version-in-last-changelog
[   26s] The latest changelog entry doesn't contain a version. Please insert the
[   26s] version that is coherent with the version of the package and rebuild it.

[dirkmueller]

@zaitor but there isn't a "version-in-last-changelog" ? is there anywhere a version number in the text that matches the rpm version?

[zaitor]

The warning is just plain wrong -- with a .changes like below, no complaints about no-version-in-last-changelog

+-------------------------------------------------------------------
+Wed Aug 29 13:06:29 UTC 2018 - [email protected]
+
+- Dummy entry.
+
 -------------------------------------------------------------------

[zaitor]

Actually, it seems it has nothing to do with my ø

Even with this:

Index: dconf.changes
===================================================================
--- dconf.changes       (revision 7457f3f4f8f624f9f31d779e1256bac0)
+++ dconf.changes       (working copy)
@@ -1,5 +1,5 @@
 -------------------------------------------------------------------
-Tue Aug 28 19:48:33 UTC 2018 - [email protected]
+Wed Aug 29 13:21:31 UTC 2018 - Bjorn Lie <[email protected]>
 
 - Update to version 0.29.2:
   + Service: When corrupt GVDB files are found, they are now

I get

[   19s] RPMLINT report:
[   19s] ===============
[   20s] dconf-devel.x86_64: W: no-version-in-last-changelog
[   20s] dconf.src: W: no-version-in-last-changelog
[   20s] dconf.x86_64: W: no-version-in-last-changelog
[   20s] gsettings-backend-dconf.x86_64: W: no-version-in-last-changelog
[   20s] libdconf1.x86_64: W: no-version-in-last-changelog
[   20s] The latest changelog entry doesn't contain a version. Please insert the
[   20s] version that is coherent with the version of the package and rebuild it.

So it seems it's the real name in itself that trips up rpmlint

[Conan-Kudo]

Are we sure that's exactly the case?

The relevant code for this check does not read the CHANGELOGNAME property of changelog entries at all: https://github.com/rpm-software-management/rpmlint/blob/rpmlint-1.x/TagsCheck.py#L737-L761

[DimStar77]

Upstream uses a regex like this:

changelog_version_regex = re.compile(r'[^>]([^ >]+)\s*$')

Now, with the OLD syntax, the email address was not wrapped into < >

* Fri Dec 28 2018 Dominique Leuenberger <[email protected]>
- BOO
* Tue Sep 11 2018 [email protected]
- update to version 3.10.0

The regex matches 'everything after the email address wrapped in < >, so in case we don't have an email address, actually 'just the last word' - which in the old format used to be the email address (and thus being used as version-release)

This should actually trigger the warning incoherent-version-in-changelog in the old formatted changes files

[DimStar77]

ah - and rpmlint's config we install by default contains:

addFilter('incoherent-version-in-changelog') which explains why this error was not spit out all the time.

So, since we esssentially never cared for version-in-changelog, I'd propose to change UseVersionInChangelog to False in the openSUSE rpmlint config

@dirkmueller ?

[dirkmueller]

I've disabled this code path in our config.

[darix]

when will this hit TW? can you also submit the fix to 15.0 as maintenance update?! TIA