--shell-cmd is ignored

[pjaitken]

The osc shell "--shell-cmd" is ignored.

When I use "osc chroot" I'm put into /home/abuild, whereas I want to run gdb in another dir - so it seems that --shell-cmd could be useful:

$ osc --version
0.168.0

$ osc help shell
...

    osc shell [OPTS] REPOSITORY ARCH

OPTS may be

    --shell-cmd=COMMAND

However --shell-cmd seems to be ignored.

Given

osc shell --root=/var/tmp/osc-buildpackage/build-root/whatever --shell-cmd date

commandline.py parses shell/chroot at lines 6475 - 6495, building opts and args for osc.build.run_build. shell-cmd is contained in opts, while args is:

args=['--root=/var/tmp/osc-buildpackage/build-root/whatever', '--noinit', '--shell']

run_build ignores opts (so shell-cmd is lost), and passes these args to run_external:

filename=sudo, args=/usr/bin/build, kwargs=--root=/var/tmp/osc-buildpackage/build-root/whatever

Ultimately this runs

/usr/bin/build --root=/var/tmp/osc-buildpackage/build-root/whatever --noinit --shell --norootforbuild

Then looking at /usr/bin/build, since --noinit is given it runs "chroot" about line 1139 without reference to RUN_SHELL_CMD. It needs to do something like:

chroot $BUILD_ROOT "${RUN_SHELL_CMD:=/bin/bash}"

[adrianschroeter]

On Freitag, 13. März 2020, 12:51:44 CET wrote pjaitken:

The osc shell "--shell-cmd" is ignored. When I use "osc chroot" I'm put into /home/abuild, whereas I want to run gdb in another dir - so it seems that --shell-cmd could be useful: > $ osc --version > 0.168.0 > > $ osc help shell > ... > > osc shell [OPTS] REPOSITORY ARCH > > OPTS may be > > --shell-cmd=COMMAND However --shell-cmd seems to be ignored.

yes and also -x for installation additional packages. It is a temporary regression for chroot, only working atm with KVM. But we will look into it again. bye adrian

…

Given osc shell --root=/var/tmp/osc-buildpackage/build-root/whatever --shell-cmd date commandline.py parses shell/chroot at lines 6475 - 6495, building opts and args for osc.build.run_build. shell-cmd is contained in opts, while args is: args=['--root=/var/tmp/osc-buildpackage/build-root/whatever', '--noinit', '--shell'] run_build ignores opts (so shell-cmd is lost), and passes these args to run_external: filename=sudo, args=/usr/bin/build, kwargs=--root=/var/tmp/osc-buildpackage/build-root/whatever Ultimately this runs /usr/bin/build --root=/var/tmp/osc-buildpackage/build-root/whatever --noinit --shell --norootforbuild Then looking at /usr/bin/build, since --noinit is given it runs "chroot" about line 1139 without reference to RUN_SHELL_CMD. It needs to do something like: chroot $BUILD_ROOT "${RUN_SHELL_CMD:=/bin/bash}"

-- Adrian Schroeter email: [email protected] SUSE Linux GmbH, GF: Felix Imendörffer, Jane Smithard, Graham Norton, HRB 21284 (AG Nürnberg) Maxfeldstraße 5 90409 Nürnberg Germany