Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add swappy options to screenshot mode menu #164

Open
FilippoBonazziSUSE opened this issue Jun 14, 2024 Discussed in #157 · 1 comment
Open

Add swappy options to screenshot mode menu #164

FilippoBonazziSUSE opened this issue Jun 14, 2024 Discussed in #157 · 1 comment
Assignees

Comments

@FilippoBonazziSUSE
Copy link
Collaborator

Discussed in #157

Originally posted by FilippoBonazziSUSE March 19, 2024
I recently found the need to edit a screenshot after it has been taken, adding text, arrows, colours etc. like one does all the time on their phone for example.

swappy can do it quite well. I am makinig a note for myself to provide a configuration for this in openSUSEway and offer it as an option in the screenshot mode menu when I have time.

@FilippoBonazziSUSE FilippoBonazziSUSE added this to the 0.17.0 milestone Jun 14, 2024
@FilippoBonazziSUSE FilippoBonazziSUSE self-assigned this Jun 14, 2024
@FilippoBonazziSUSE
Copy link
Collaborator Author

This is kind of tricky to provide in the general case, as swappy saves the resulting image in two places depending on how it's used:

  1. it saves the image to somewhere specified by a -o option (which can be stdout, which would make it play nice with grim) upon exiting the program
  2. it saves the image to somewhere specified by the save_dir configuration value (no CLI option), which defaults to $HOME/Desktop if the "Save" button is pressed

This difference is undesirable for the user, which would conceivably want to have all their screenshots end up in a single folder. We have deferred setting a default screenshot folder so far (#139), but the issue now would become unavoidable.
To use swappy in a coherent manner, we would need to set the same screenshot destination folder (whatever it is) to be used by grim AND by swappy when using the "Save" button.

Since this is becoming so tricky, I don't think I can get this done by next week in time for the conference.
@denisok FYI

@FilippoBonazziSUSE FilippoBonazziSUSE removed this from the 0.17.0 milestone Jun 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant