Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Loan gets approved in spite of "Approved Amount" and "Transaction Amount" field being blank #666

Closed
AbhilashG97 opened this issue Apr 8, 2017 · 3 comments

Comments

@AbhilashG97
Copy link
Member

Summary:

Loan gets approved in spite of "Approved Amount" and "Transaction Amount" field being blank. An appropriate response like a toast message stating that the field cannot be blank would be suitable.

Steps to reproduce:

Step 1) Open the app.
Step 2) Tap on the Clients fragment from the navigation drawer.
Step 3) Select a Client.
Step 4) Tap on Loan Accounts and select an account in which a loan needs to be approved.
Step 5) Tap on "Approve Loan" button.
Step 6) Leave the "Approved Amount" and "Transaction Amount" field empty.
Step 6) Tap on Submit.

Expected behavior:

The loan shouldn't get approved and an appropriate error message should notify the user about the blank fields.

Observed behavior:

The loan gets approved in spite of the "Approved Amount" and "Transaction Amount" field being blank.

Device and Android version:

Device : Motorola Moto G 1st Generation [XT1033] [Falcon]
ROM : CyanogenMod 13.0 Snapshot build

GIF:

videotogif_2017 04 08_18 41 23

@AbhilashG97
Copy link
Member Author

I would like to work on this issue.

@AbhilashG97
Copy link
Member Author

I have made appropriate changes, please review my pull request and kindly let me know if I have to make any further changes.
Pull request - #668

@therajanmaurya
Copy link
Member

fix in #668

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants