Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update tag_storage_types.yaml #338

Merged
merged 1 commit into from
Jun 18, 2024

Conversation

sandrinecharousset
Copy link
Collaborator

The comment says 'does not include hydro' but Pumped Storage was still included.... which would create variables such as eg Capacity|Electricity|Pumped Storage while the use of Electricity Input creates Capacity|Electricity|Hydro|Pumped storage I propose to remove pumped storage from storage_types

The comment says 'does not include hydro' but Pumped Storage was still included.... which would create variables such as eg Capacity|Electricity|Pumped Storage while the use of Electricity Input creates Capacity|Electricity|Hydro|Pumped storage
I propose to remove pumped storage from storage_types
@erikfilias
Copy link
Collaborator

@sandrinecharousset, I also agree. Because some variables related to storage_type are also defined for pumped-storage hydro. For example: Charging Efficiency|Electricity|Hydro|Pumped Storage: in power-plant.yaml.

@sandrinecharousset
Copy link
Collaborator Author

@phackstock could you have a look and merge if ok?

@phackstock phackstock merged commit 2ee9df3 into openENTRANCE:main Jun 18, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants