Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

files tag_electricity and tag_fuel_types #179

Open
sandrinecharousset opened this issue May 10, 2022 · 3 comments
Open

files tag_electricity and tag_fuel_types #179

sandrinecharousset opened this issue May 10, 2022 · 3 comments

Comments

@sandrinecharousset
Copy link
Collaborator

Those 2 files are 90% identical : is there a reason why the 2 exist? SHouldn't we merge them? It may create unconcistencies if one is modified and not the other....
@danielhuppmann @tburandt @erikfilias any idea?

@erikfilias
Copy link
Collaborator

paths of the 2 files: https://github.com/openENTRANCE/openentrance/blob/3143bfb24f91f868ef3a8134a0620aa0556b68ab/definitions/variable/tag_electricity_input_types.yaml https://github.com/openENTRANCE/openentrance/blob/3143bfb24f91f868ef3a8134a0620aa0556b68ab/definitions/variable/tag_fuel_types.yaml

From my understanding, we created the tag_fuel_types at the beginning for naming the sources of the electricity generation.
However, now, it is the purpose of tag_electricity. I'm not sure the purpose of the fuel types since it is not considered for electricity generation, but maybe it is useful for other energy carriers.

@sandrinecharousset
Copy link
Collaborator Author

sandrinecharousset commented May 11, 2022

@erikfilias , I finally digged the directory and found an old discussion raised by @HauHe about this which explains why there are 2 different files
What I understand is that fuel_types is only for fuels eg you will find gas|biomethane but not gas|ocgt, or solar and not solar|pv
while electricity_input is for creating all names of different power plants, where you may have much more different cases such as gas|biomethane|ocgt , gas|ccgt......
So in the end I believe that unless we find a better way (which may be tricky), we stick to that separation.....
Sorry for raising an irrelevant issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants