Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Laforge/debian packaging #3

Merged
merged 5 commits into from
Nov 2, 2017

Conversation

laf0rge
Copy link
Contributor

@laf0rge laf0rge commented Oct 17, 2017

This is a pull request for changes that

  • rename the binaries with a prefix to indicate they're part of nextepc
  • fix various bits of autotools errors (prefix vs. libdir vs. sysconfdir; DESTDIR)
  • add systemd service files
  • add debian packaging information

As a result, at least on Debian unstable ,one can now build nextepc-{hss,mme,sgw,pgw} packages for nextepc.

'mmed' and the like all are a bit of a generic name. Let's prefix the
project name to ensure there will be no clashes with other programs that
also implement a 'MME daemon' or the like.
When creating the /var/log directory, we must create it relative
to the $(DESTDIR) of the installation, and not at it's system-wide
default path without any DESTDIR.
…statedir@

Installing to @Prefix@/etc is wrong, this will end up in /usr/etc
on most linux distributions, where /etc (@sysconfdir@) would be correct.

The same is true for /var (@localstatedir@), we don't want log files
suddenly to be in /usr/var/log rather than /var/log

However, this is further complicated by the fact that @libdir@ is not
recursively resolved but could expand to "${prefix}/lib" which
of course makes no sense inside a config file.  So instead, let's
introduce adl_RECURSIVE_EVAL and define @LIB_DIR@ and @SYSCONF_DIR@
with recursively-expanded versions of those variables.
@acetcom
Copy link
Member

acetcom commented Oct 18, 2017

Great! That is what I wanted to do.

But I have a one question. Could you move your debian and systemd directories from the root directory to another directory? What about the in-subdirectory of contrib or support?

Something like that...Either way is good for me.

├── support
│   ├── systemd
├── contrib
│   └── debian

or

├── contrib
│   ├── debian
│   └── systemd

or

├── support
│   ├── debian
│   └── systemd

Thank you for your efforts.

@laf0rge
Copy link
Contributor Author

laf0rge commented Oct 18, 2017

For "systemd" it's possible. For "debian" I don't think it's not possible. Look at the source code of any project with debian packaging: It's always in the top-directory "debian". It's where all the packaging tools (dpkg-buildpackage, debhelpers, etc.) expect it.

FYI: OBS builds successfully on Debian 9, Ubuntu 16.10 and 17.04: https://build.opensuse.org/package/show/home:laforge:nextepc/nextepc#

For Ubuntu 16.04, I'm trying to make it work by downgrading to debhelper 9.

@acetcom
Copy link
Member

acetcom commented Oct 18, 2017

Wow! I'm happy to see the package link you referred to.
That sounds good to me.

BTW, I've never created a debian package. -_-; If "debian" need to be located in the top-directory, I don't care "systemd" directory also. The best place you think is where I want to be for such two directory.

Do you want to merge right now? or waiting for fixing the Ubuntu 16.04 package?

Thank you very much!

@laf0rge laf0rge force-pushed the laforge/debian-packaging branch from 3f9b632 to 24a388b Compare October 18, 2017 09:04
@laf0rge
Copy link
Contributor Author

laf0rge commented Oct 18, 2017

please wait, I have some updates pending.

@laf0rge laf0rge closed this Oct 18, 2017
@laf0rge laf0rge reopened this Oct 18, 2017
Adding this 'debian' subdirectory will allow users to build
binary packages using 'dpkg-buildpackage' and related tools.

Tested so far on Debian unstable and 9 as well as Ubuntu 17.04
and 17.10 on OpenSuSE Build Service.
@laf0rge laf0rge force-pushed the laforge/debian-packaging branch from 24a388b to ae6f100 Compare October 18, 2017 10:28
@acetcom acetcom merged commit ae6f100 into open5gs:master Nov 2, 2017
acetcom added a commit that referenced this pull request Sep 21, 2019
ogs-sha[12]-hmac: Ensure input (key, message) are not modified
@t1412 t1412 mentioned this pull request Jul 1, 2021
@micjerry micjerry mentioned this pull request Nov 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants