Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug: reducable balance should incorporate ED in case of Preservation::Preserve mode #986

Closed
dmoka opened this issue Mar 28, 2024 · 3 comments
Closed

Bug: reducable balance should incorporate ED in case of Preservation::Preserve mode #986

dmoka opened this issue Mar 28, 2024 · 3 comments

Comments

@dmoka
Copy link
Contributor

dmoka commented Mar 28, 2024 •
edited
Loading

Description

In the implementation of the reducable_balance you return the liquid balance when the preservation is not Preservation::Protect.

I think this is a bug, and we should return liquid balance when preservation mode is neither Protect or 'Preserve'.
@xlc
Copy link
Member

xlc commented Mar 29, 2024

Right. Do you mind opening a quick PR to fix it?

@dmoka
Copy link
Contributor Author

dmoka commented Mar 29, 2024

Right. Do you mind opening a quick PR to fix it?

Thanks for the quick validation. Sure, I can pick it up.

This was referenced Apr 5, 2024
Closed
Merged
@dmoka
Copy link
Contributor Author

dmoka commented Apr 5, 2024

#987

@zjb0807 zjb0807 closed this as completed May 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@xlc @dmoka @zjb0807