Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

openvsx extension missing included npm_modules #512

Closed
matkoniecz opened this issue Nov 25, 2021 · 6 comments
Closed

openvsx extension missing included npm_modules #512

matkoniecz opened this issue Nov 25, 2021 · 6 comments

Comments

@matkoniecz
Copy link

PeterWone/vsc-print extensions fails to install in VSCodium what is caused by corruption of extension package by openvsx

I am not the first affected person, see PDConSec/vsc-print#116

I reported it as VScodium bug but appears to be openvsx bug, see VSCodium/vscodium#928

entire node_modules was missing.

It is also missing from VSIX file at https://open-vsx.org/extension/pdconsec/vscode-print

It is not missing from VSIX file at https://marketplace.visualstudio.com/items?itemName=pdconsec.vscode-print

Published by open-vsx

so I am reporting it here

@matkoniecz
Copy link
Author

pure guessing:

Maybe https://github.com/PeterWone/vsc-print/blob/master/.vscodeignore#L23 is not parsed?

See also eclipse/openvsx#376 (comment) by extension author:

In respect of @matkoniecz speculation that .vscodeignore#L23 is not parsed - Microsoft briefly changed the way this file was parsed to make it consistent with other things. I raised an issue about problems this caused and the outcome was they reverted the change.

It is possible that this change and reversion has contributed.

@matkoniecz
Copy link
Author

See also:

@akosyakov
Copy link
Collaborator

Extension was removed from OpenVSX as requested by the author: eclipse/openvsx#377
Please up-vote instead: PDConSec/vsc-print#120

@matkoniecz
Copy link
Author

Extension was removed from OpenVSX as requested by the author: eclipse/openvsx#377

If I read it correctly author is fine with publishing version obeying MIT license - and that is not fatally broken while being attributed to them.

@akosyakov
Copy link
Collaborator

The author asked explicitly to take it down from auto publishing and going to publish himself instead: eclipse/openvsx#377 (comment)

@AS400JPLPC
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants