Check whether extension has an OSI approved license #513
Conversation
lib/resolveExtension.js
Outdated
| @@ -53,6 +54,26 @@ exports.resolveExtension = async function ({ id, repository, location }, ms) { | |||
| await exec(`git clone --filter=blob:none --recurse-submodules ${repository} ${repoPath}`, { quiet: true }); | |||
|
|
|||
| const packagePath = [repoPath, location, 'package.json'].filter(p => !!p).join('/'); | |||
|
|
|||
| //#region Check if the extension has an OSI-approved open-source license | |||
| try { | |||
There was a problem hiding this comment.
Should not we check a revision form which we build vsix file?
There was a problem hiding this comment.
Great catch, @akosyakov, I was thinking about doing that, settled on "licenses don't change from commit to commit, right?". In edge cases where a license might be changed, added, or removed, I'll integrate it into the resolveVersion function to avoid otherwise duplicating the code over and over.
publish-extensions/lib/resolveExtension.js
Lines 60 to 71 in 4d65730
There was a problem hiding this comment.
Just looked into this again, and it seems there is no way to fetch the license for a specific time in the repository, just the current state. I checked with both the REST and GraphQL APIs, the only parameters allowed are name and owner.
akosyakov
force-pushed
the
master
branch
2 times, most recently
from
da64976
to
2baee1c
Compare
Fixes #510
How to test
extensions.jsonGITHUB_TOKEN, so that the script can request the GitHub API for the license)ToDo