Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue522: Capture is failing in tests in 9.20 #35

Merged
merged 4 commits into from
Apr 25, 2022
Merged

Issue522: Capture is failing in tests in 9.20 #35

merged 4 commits into from
Apr 25, 2022

Conversation

ASHNA-AGGARWAL-KEYSIGHT
Copy link
Collaborator

@ASHNA-AGGARWAL-KEYSIGHT ASHNA-AGGARWAL-KEYSIGHT commented Apr 21, 2022 •
edited
Loading

@ajbalogh ajbalogh self-requested a review April 21, 2022 04:14
ajbalogh
ajbalogh reviewed Apr 21, 2022
View reviewed changes
Copy link

@ajbalogh ajbalogh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this change fulfill the capture config format that is in the model?
The model allows for both pcap and pcapng - should we be supporting both?

@ANISH-GOTTAPU
Copy link
Contributor

@ajbalogh : We are not going to merge the PR associated with this, We would like to know if anything else is breaking with 9.20. The issue is just a place holder for capture issue related to ixN 9.20

@ASHNA-AGGARWAL-KEYSIGHT ASHNA-AGGARWAL-KEYSIGHT marked this pull request as draft April 21, 2022 04:22
@ASHNA-AGGARWAL-KEYSIGHT
Copy link
Collaborator Author

Have change it to draft to avoid confusion

@ASHNA-AGGARWAL-KEYSIGHT ASHNA-AGGARWAL-KEYSIGHT marked this pull request as ready for review April 25, 2022 10:10
@ANISH-GOTTAPU
Copy link
Contributor

@ajbalogh : We had internal discussion and thought of moving CI/CD to 9.20. Though 9.20 supports only pcapng, we will raise a warning with snappi-ixnetwork that pcap is not supported.

There is another discussion that is happening with Mario(IxNetwork Analyzer Team) and we have to take a call whether to keep the support in models or not based on conclusion.

@ankur-sheth & @ashutshkumr : FYI

@ASHNA-AGGARWAL-KEYSIGHT ASHNA-AGGARWAL-KEYSIGHT merged commit 2a4d6c6 into main Apr 25, 2022
@ASHNA-AGGARWAL-KEYSIGHT ASHNA-AGGARWAL-KEYSIGHT deleted the capture_changes branch April 25, 2022 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ajbalogh ajbalogh ajbalogh left review comments

@ANISH-GOTTAPU ANISH-GOTTAPU Awaiting requested review from ANISH-GOTTAPU

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

PCAP support is removed Capture is failing in tests in 9.20
3 participants
@ASHNA-AGGARWAL-KEYSIGHT @ANISH-GOTTAPU @ajbalogh