Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publish docker image with for arm64 platform #345

Closed
jack-berg opened this issue Aug 26, 2024 · 2 comments · Fixed by #346
Closed

Publish docker image with for arm64 platform #345

jack-berg opened this issue Aug 26, 2024 · 2 comments · Fixed by #346

Comments

@jack-berg
Copy link
Member

jack-berg commented Aug 26, 2024

While incorporating weaver into semantic-conventions-java, we discovered that the weaver docker image doesn't have multi platform support, so running it in arm64 requires this extra argument.

Apparently the otel/weaver image doesn't publish for arm64 platform yet.

        "--rm",
        "--platform=linux/x86_64",

Originally posted by @jack-berg in open-telemetry/semantic-conventions-java#70 (comment)

@jsuereth
Copy link
Contributor

This looks to be not too hard using docker-provided actions: https://docs.docker.com/build/ci/github-actions/multi-platform/

@jsuereth
Copy link
Contributor

So while I got a build working - It looks like we DON'T want to pay the rust compiler cost through QEMU emulation.

I'll lookinto updating the PR for this guidance: https://docs.docker.com/build/ci/github-actions/multi-platform/#distribute-build-across-multiple-runners

@lquerel lquerel closed this as completed in cdea78f Sep 9, 2024
@github-project-automation github-project-automation bot moved this from To consider for the next release to Done in OTel Weaver Project Sep 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants