Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add k8s.container.status.last_terminated_reason resource attribute #968

Merged
merged 2 commits into from
Apr 30, 2024

Conversation

povilasv
Copy link
Contributor

Fixes #922

Changes

Merge requirement checklist

@povilasv povilasv force-pushed the k8s-status branch 2 times, most recently from c344e0b to 3ce96d8 Compare April 25, 2024 11:34
@povilasv povilasv marked this pull request as ready for review April 25, 2024 11:35
@povilasv povilasv requested review from a team April 25, 2024 11:35
@ChrsMark
Copy link
Member

FYI @open-telemetry/specs-semconv-approvers @open-telemetry/specs-semconv-maintainers

Copy link
Contributor

@lmolkova lmolkova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
Left a couple of minor comments

.chloggen/k8s-status.yaml Outdated Show resolved Hide resolved
model/resource/k8s.yaml Outdated Show resolved Hide resolved
@povilasv
Copy link
Contributor Author

@lmolkova updated based on your feedback, please take a look again 🙇

@lmolkova lmolkova merged commit 3dc61e1 into open-telemetry:main Apr 30, 2024
12 checks passed
@povilasv povilasv deleted the k8s-status branch April 30, 2024 04:17
drewby pushed a commit to drewby/otel-semantic-conventions that referenced this pull request May 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Add k8s.container.status.last_terminated_reason to semantic conventions.
6 participants