Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore] revert temp fix for resource attributes #702

Merged
merged 8 commits into from
Feb 12, 2024

Conversation

trisch-me
Copy link
Contributor

Reverts #524

Changes

As the fix in open-telemetry/build-tools#243 was merged we can revert type of attributes in global registry to be just attribute_group and not resource.

Merge requirement checklist

@trisch-me trisch-me changed the title revert temp fix for resource attributes [chore] revert temp fix for resource attributes Feb 9, 2024
Copy link
Contributor

@jsuereth jsuereth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yay!

@joaopgrassi joaopgrassi merged commit 352293d into open-telemetry:main Feb 12, 2024
10 checks passed
ChrsMark pushed a commit to ChrsMark/semantic-conventions that referenced this pull request Feb 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants