From 267264054cc5f79baadc2ea16630b495df1b157b Mon Sep 17 00:00:00 2001 From: Anna Levenberg Date: Mon, 20 Nov 2023 11:55:58 -0500 Subject: [PATCH 01/14] docs(messaging): add message link attribute and example for batch publish --- CHANGELOG.md | 2 ++ docs/attributes-registry/messaging.md | 1 + docs/messaging/gcp-pubsub.md | 43 +++++++++++++++++++++++++++ model/registry/messaging.yaml | 5 ++++ model/trace/messaging.yaml | 3 ++ 5 files changed, 54 insertions(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index 0e6f2f2257..2a8c0267bd 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -29,6 +29,8 @@ release. ([#21](https://github.com/open-telemetry/semantic-conventions/pull/21)) - Add `messaging.gcp_pubsub.message.ordering_key` attribute. ([#528](https://github.com/open-telemetry/semantic-conventions/pull/528)) +- Add `messaging.gcp_pubsub.message.link` attribute and an example for gcp_pubsub + asynchronous batch publish. ### Fixes diff --git a/docs/attributes-registry/messaging.md b/docs/attributes-registry/messaging.md index 626d8cc59f..a3e1ee710a 100644 --- a/docs/attributes-registry/messaging.md +++ b/docs/attributes-registry/messaging.md @@ -16,6 +16,7 @@ | `messaging.destination.temporary` | boolean | A boolean that is true if the message destination is temporary and might not exist anymore after messages are processed. | | | `messaging.destination_publish.anonymous` | boolean | A boolean that is true if the publish message destination is anonymous (could be unnamed or have auto-generated name). | | | `messaging.destination_publish.name` | string | The name of the original destination the message was published to [4] | `MyQueue`; `MyTopic` | +| `messaging.gcp_pubsub.message.link` | int | An identifier for the link. This is *not* the message id. The number will be in between 0 and the max batch size. | `1` | | `messaging.gcp_pubsub.message.ordering_key` | string | The ordering key for a given message. If the attribute is not present, the message does not have an ordering key. | `ordering_key` | | `messaging.kafka.consumer.group` | string | Name of the Kafka Consumer Group that is handling the message. Only applies to consumers, not producers. | `my-group` | | `messaging.kafka.destination.partition` | int | Partition the message is sent to. | `2` | diff --git a/docs/messaging/gcp-pubsub.md b/docs/messaging/gcp-pubsub.md index 08027ce032..94bfaa9b3d 100644 --- a/docs/messaging/gcp-pubsub.md +++ b/docs/messaging/gcp-pubsub.md @@ -16,7 +16,50 @@ For Google Cloud Pub/Sub, the following additional attributes are defined: | Attribute | Type | Description | Examples | Requirement Level | |---|---|---|---|---| +| [`messaging.gcp_pubsub.message.link`](../attributes-registry/messaging.md) | int | An identifier for the link. This is *not* the message id. The number will be in between 0 and the max batch size. | `1` | Recommended | | [`messaging.gcp_pubsub.message.ordering_key`](../attributes-registry/messaging.md) | string | The ordering key for a given message. If the attribute is not present, the message does not have an ordering key. | `ordering_key` | Conditionally Required: If the message type has an ordering key set. | + +## Examples + +### Asynchronous Batch Publish Example + +Given is a process P that asynchronously publishes 2 messages in a batch to a topic T on Pub/Sub. + +```mermaid +flowchart LR; + subgraph PRODUCER + direction LR + CA[Span Create A] + CB[Span Create B] + P[Span Publish] + end + CA-. link .-P; + CB-. link .-P; + + classDef normal fill:green + class PA,PB,D1 normal + linkStyle 0,1 color:green,stroke:green +``` + +| Field or Attribute | Span Create A | Span Create B | Span Publish A B | +|-|-|-|-| +| Span name | `T create` | `T create` | `publish` | +| Parent | | | | +| Links | | | Span Create A, Span Create B | +| Link attributes [1]| | | Span Create A: `messaging.gcp_pubsub.message.link`: `1` | +| | | | Span Create B: `messaging.gcp_pubsub.message.link`: `2` | +| SpanKind | `PRODUCER` | `PRODUCER` | `PRODUCER` | +| Status | `Ok` | `Ok` | `Ok` | +| `messaging.batch.message_count` | | | 2 | +| `messaging.destination.name` | `"T"` | `"T"` | | +| `messaging.destination.template` | `"topic"` | `"topic"` | | +| `messaging.operation` | `"create"` | `"create"` | `"publish"` | +| `messaging.message.id` | `"a1"` | `"a2"` | | +| `messaging.message.total_size_bytes` | `1` | `1` | | +| `messaging.system` | `"gcp_pubsub"` | `"gcp_pubsub"` | | + +**[1]:** A message receives its id after the publish span completes. The message link attribute represenets + [DocumentStatus]: https://github.com/open-telemetry/opentelemetry-specification/tree/v1.26.0/specification/document-status.md diff --git a/model/registry/messaging.yaml b/model/registry/messaging.yaml index c7ba8fd457..c72f6fb71c 100644 --- a/model/registry/messaging.yaml +++ b/model/registry/messaging.yaml @@ -207,6 +207,11 @@ groups: brief: > The ordering key for a given message. If the attribute is not present, the message does not have an ordering key. examples: 'ordering_key' + - id: gcp_pubsub.message.link + type: int + brief: > + An identifier for the link. This is *not* the message id. The number will be in between 0 and the max batch size. + examples: 1 - id: system brief: > An identifier for the messaging system being used. See below for a list of well-known identifiers. diff --git a/model/trace/messaging.yaml b/model/trace/messaging.yaml index 9163de0b4b..7d78d10cf3 100644 --- a/model/trace/messaging.yaml +++ b/model/trace/messaging.yaml @@ -180,3 +180,6 @@ groups: tag: tech-specific-gcp-pubsub requirement_level: conditionally_required: If the message type has an ordering key set. + - ref: messaging.gcp_pubsub.message.link + tag: tech-specific-gcp-pubsub + requirement_level: recommended \ No newline at end of file From eb35b46d3dc865a0cc4f47436e02d8e78e4beddb Mon Sep 17 00:00:00 2001 From: Anna Levenberg Date: Mon, 20 Nov 2023 15:36:44 -0500 Subject: [PATCH 02/14] add to changelog --- CHANGELOG.md | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 2a8c0267bd..b9b2eb0a8a 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -30,7 +30,8 @@ release. - Add `messaging.gcp_pubsub.message.ordering_key` attribute. ([#528](https://github.com/open-telemetry/semantic-conventions/pull/528)) - Add `messaging.gcp_pubsub.message.link` attribute and an example for gcp_pubsub - asynchronous batch publish. + asynchronous batch publish + ([#548](https://github.com/open-telemetry/semantic-conventions/pull/545)). ### Fixes From a7bf626eed274bc72dbbab96c807146c22381d6c Mon Sep 17 00:00:00 2001 From: Anna Levenberg Date: Mon, 20 Nov 2023 15:37:07 -0500 Subject: [PATCH 03/14] linter --- CHANGELOG.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index b9b2eb0a8a..ec599e7fa3 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -30,7 +30,7 @@ release. - Add `messaging.gcp_pubsub.message.ordering_key` attribute. ([#528](https://github.com/open-telemetry/semantic-conventions/pull/528)) - Add `messaging.gcp_pubsub.message.link` attribute and an example for gcp_pubsub - asynchronous batch publish + asynchronous batch publish ([#548](https://github.com/open-telemetry/semantic-conventions/pull/545)). ### Fixes From 1674080b425632be35f7d72bcce1072962e70bab Mon Sep 17 00:00:00 2001 From: Anna Levenberg Date: Mon, 20 Nov 2023 15:42:44 -0500 Subject: [PATCH 04/14] linter --- docs/messaging/gcp-pubsub.md | 1 - model/trace/messaging.yaml | 2 +- 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/docs/messaging/gcp-pubsub.md b/docs/messaging/gcp-pubsub.md index 94bfaa9b3d..328ec2b478 100644 --- a/docs/messaging/gcp-pubsub.md +++ b/docs/messaging/gcp-pubsub.md @@ -20,7 +20,6 @@ For Google Cloud Pub/Sub, the following additional attributes are defined: | [`messaging.gcp_pubsub.message.ordering_key`](../attributes-registry/messaging.md) | string | The ordering key for a given message. If the attribute is not present, the message does not have an ordering key. | `ordering_key` | Conditionally Required: If the message type has an ordering key set. | - ## Examples ### Asynchronous Batch Publish Example diff --git a/model/trace/messaging.yaml b/model/trace/messaging.yaml index 7d78d10cf3..e7d90dcb7b 100644 --- a/model/trace/messaging.yaml +++ b/model/trace/messaging.yaml @@ -182,4 +182,4 @@ groups: conditionally_required: If the message type has an ordering key set. - ref: messaging.gcp_pubsub.message.link tag: tech-specific-gcp-pubsub - requirement_level: recommended \ No newline at end of file + requirement_level: recommended From 22cdd03b57e57be79b01ff353fbbbead3dc9bd17 Mon Sep 17 00:00:00 2001 From: Anna Levenberg Date: Wed, 29 Nov 2023 11:10:56 -0500 Subject: [PATCH 05/14] remove message link attribute and add update example --- CHANGELOG.md | 3 +-- docs/attributes-registry/messaging.md | 2 -- docs/messaging/gcp-pubsub.md | 9 +++------ model/registry/messaging.yaml | 5 ----- model/trace/messaging.yaml | 3 --- 5 files changed, 4 insertions(+), 18 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index ec599e7fa3..4390271bc1 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -29,8 +29,7 @@ release. ([#21](https://github.com/open-telemetry/semantic-conventions/pull/21)) - Add `messaging.gcp_pubsub.message.ordering_key` attribute. ([#528](https://github.com/open-telemetry/semantic-conventions/pull/528)) -- Add `messaging.gcp_pubsub.message.link` attribute and an example for gcp_pubsub - asynchronous batch publish +- Add an example for gcp_pubsub asynchronous batch publish ([#548](https://github.com/open-telemetry/semantic-conventions/pull/545)). ### Fixes diff --git a/docs/attributes-registry/messaging.md b/docs/attributes-registry/messaging.md index a3e1ee710a..fe5523c85d 100644 --- a/docs/attributes-registry/messaging.md +++ b/docs/attributes-registry/messaging.md @@ -16,8 +16,6 @@ | `messaging.destination.temporary` | boolean | A boolean that is true if the message destination is temporary and might not exist anymore after messages are processed. | | | `messaging.destination_publish.anonymous` | boolean | A boolean that is true if the publish message destination is anonymous (could be unnamed or have auto-generated name). | | | `messaging.destination_publish.name` | string | The name of the original destination the message was published to [4] | `MyQueue`; `MyTopic` | -| `messaging.gcp_pubsub.message.link` | int | An identifier for the link. This is *not* the message id. The number will be in between 0 and the max batch size. | `1` | -| `messaging.gcp_pubsub.message.ordering_key` | string | The ordering key for a given message. If the attribute is not present, the message does not have an ordering key. | `ordering_key` | | `messaging.kafka.consumer.group` | string | Name of the Kafka Consumer Group that is handling the message. Only applies to consumers, not producers. | `my-group` | | `messaging.kafka.destination.partition` | int | Partition the message is sent to. | `2` | | `messaging.kafka.message.key` | string | Message keys in Kafka are used for grouping alike messages to ensure they're processed on the same partition. They differ from `messaging.message.id` in that they're not unique. If the key is `null`, the attribute MUST NOT be set. [5] | `myKey` | diff --git a/docs/messaging/gcp-pubsub.md b/docs/messaging/gcp-pubsub.md index 328ec2b478..e5af8c467b 100644 --- a/docs/messaging/gcp-pubsub.md +++ b/docs/messaging/gcp-pubsub.md @@ -16,7 +16,6 @@ For Google Cloud Pub/Sub, the following additional attributes are defined: | Attribute | Type | Description | Examples | Requirement Level | |---|---|---|---|---| -| [`messaging.gcp_pubsub.message.link`](../attributes-registry/messaging.md) | int | An identifier for the link. This is *not* the message id. The number will be in between 0 and the max batch size. | `1` | Recommended | | [`messaging.gcp_pubsub.message.ordering_key`](../attributes-registry/messaging.md) | string | The ordering key for a given message. If the attribute is not present, the message does not have an ordering key. | `ordering_key` | Conditionally Required: If the message type has an ordering key set. | @@ -32,11 +31,13 @@ flowchart LR; direction LR CA[Span Create A] CB[Span Create B] - P[Span Publish] + P[Span Publish A B] end CA-. link .-P; CB-. link .-P; + classDef producer fill:green + class P,CA,CB producer classDef normal fill:green class PA,PB,D1 normal linkStyle 0,1 color:green,stroke:green @@ -47,8 +48,6 @@ flowchart LR; | Span name | `T create` | `T create` | `publish` | | Parent | | | | | Links | | | Span Create A, Span Create B | -| Link attributes [1]| | | Span Create A: `messaging.gcp_pubsub.message.link`: `1` | -| | | | Span Create B: `messaging.gcp_pubsub.message.link`: `2` | | SpanKind | `PRODUCER` | `PRODUCER` | `PRODUCER` | | Status | `Ok` | `Ok` | `Ok` | | `messaging.batch.message_count` | | | 2 | @@ -59,6 +58,4 @@ flowchart LR; | `messaging.message.total_size_bytes` | `1` | `1` | | | `messaging.system` | `"gcp_pubsub"` | `"gcp_pubsub"` | | -**[1]:** A message receives its id after the publish span completes. The message link attribute represenets - [DocumentStatus]: https://github.com/open-telemetry/opentelemetry-specification/tree/v1.26.0/specification/document-status.md diff --git a/model/registry/messaging.yaml b/model/registry/messaging.yaml index c72f6fb71c..c7ba8fd457 100644 --- a/model/registry/messaging.yaml +++ b/model/registry/messaging.yaml @@ -207,11 +207,6 @@ groups: brief: > The ordering key for a given message. If the attribute is not present, the message does not have an ordering key. examples: 'ordering_key' - - id: gcp_pubsub.message.link - type: int - brief: > - An identifier for the link. This is *not* the message id. The number will be in between 0 and the max batch size. - examples: 1 - id: system brief: > An identifier for the messaging system being used. See below for a list of well-known identifiers. diff --git a/model/trace/messaging.yaml b/model/trace/messaging.yaml index e7d90dcb7b..9163de0b4b 100644 --- a/model/trace/messaging.yaml +++ b/model/trace/messaging.yaml @@ -180,6 +180,3 @@ groups: tag: tech-specific-gcp-pubsub requirement_level: conditionally_required: If the message type has an ordering key set. - - ref: messaging.gcp_pubsub.message.link - tag: tech-specific-gcp-pubsub - requirement_level: recommended From 5d4a669128cf2e4299f5e7416e8879b879c18f1d Mon Sep 17 00:00:00 2001 From: Anna Levenberg Date: Wed, 29 Nov 2023 11:13:52 -0500 Subject: [PATCH 06/14] lint --- docs/attributes-registry/messaging.md | 1 + 1 file changed, 1 insertion(+) diff --git a/docs/attributes-registry/messaging.md b/docs/attributes-registry/messaging.md index fe5523c85d..626d8cc59f 100644 --- a/docs/attributes-registry/messaging.md +++ b/docs/attributes-registry/messaging.md @@ -16,6 +16,7 @@ | `messaging.destination.temporary` | boolean | A boolean that is true if the message destination is temporary and might not exist anymore after messages are processed. | | | `messaging.destination_publish.anonymous` | boolean | A boolean that is true if the publish message destination is anonymous (could be unnamed or have auto-generated name). | | | `messaging.destination_publish.name` | string | The name of the original destination the message was published to [4] | `MyQueue`; `MyTopic` | +| `messaging.gcp_pubsub.message.ordering_key` | string | The ordering key for a given message. If the attribute is not present, the message does not have an ordering key. | `ordering_key` | | `messaging.kafka.consumer.group` | string | Name of the Kafka Consumer Group that is handling the message. Only applies to consumers, not producers. | `my-group` | | `messaging.kafka.destination.partition` | int | Partition the message is sent to. | `2` | | `messaging.kafka.message.key` | string | Message keys in Kafka are used for grouping alike messages to ensure they're processed on the same partition. They differ from `messaging.message.id` in that they're not unique. If the key is `null`, the attribute MUST NOT be set. [5] | `myKey` | From 4cf830a0a35c6940314dacb13e640686a810ceda Mon Sep 17 00:00:00 2001 From: Anna Levenberg Date: Thu, 30 Nov 2023 11:06:29 -0500 Subject: [PATCH 07/14] fix attribute name to use sc --- docs/messaging/gcp-pubsub.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/messaging/gcp-pubsub.md b/docs/messaging/gcp-pubsub.md index e5af8c467b..9595d7995d 100644 --- a/docs/messaging/gcp-pubsub.md +++ b/docs/messaging/gcp-pubsub.md @@ -55,7 +55,7 @@ flowchart LR; | `messaging.destination.template` | `"topic"` | `"topic"` | | | `messaging.operation` | `"create"` | `"create"` | `"publish"` | | `messaging.message.id` | `"a1"` | `"a2"` | | -| `messaging.message.total_size_bytes` | `1` | `1` | | +| `messaging.message.envelope.size` | `1` | `1` | | | `messaging.system` | `"gcp_pubsub"` | `"gcp_pubsub"` | | [DocumentStatus]: https://github.com/open-telemetry/opentelemetry-specification/tree/v1.26.0/specification/document-status.md From 64868b3258be3742fc3f16032b5058dd45133acb Mon Sep 17 00:00:00 2001 From: Anna Levenberg Date: Thu, 30 Nov 2023 12:01:53 -0500 Subject: [PATCH 08/14] Update docs/messaging/gcp-pubsub.md Co-authored-by: Liudmila Molkova --- docs/messaging/gcp-pubsub.md | 1 - 1 file changed, 1 deletion(-) diff --git a/docs/messaging/gcp-pubsub.md b/docs/messaging/gcp-pubsub.md index 9595d7995d..03bc6df969 100644 --- a/docs/messaging/gcp-pubsub.md +++ b/docs/messaging/gcp-pubsub.md @@ -52,7 +52,6 @@ flowchart LR; | Status | `Ok` | `Ok` | `Ok` | | `messaging.batch.message_count` | | | 2 | | `messaging.destination.name` | `"T"` | `"T"` | | -| `messaging.destination.template` | `"topic"` | `"topic"` | | | `messaging.operation` | `"create"` | `"create"` | `"publish"` | | `messaging.message.id` | `"a1"` | `"a2"` | | | `messaging.message.envelope.size` | `1` | `1` | | From 4dd8c7008e6b3d93bd4a73ff77285f15fedafe39 Mon Sep 17 00:00:00 2001 From: Anna Levenberg Date: Mon, 4 Dec 2023 11:16:00 -0500 Subject: [PATCH 09/14] Update docs/messaging/gcp-pubsub.md Co-authored-by: Liudmila Molkova --- docs/messaging/gcp-pubsub.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/messaging/gcp-pubsub.md b/docs/messaging/gcp-pubsub.md index 03bc6df969..2ce869f513 100644 --- a/docs/messaging/gcp-pubsub.md +++ b/docs/messaging/gcp-pubsub.md @@ -48,7 +48,7 @@ flowchart LR; | Span name | `T create` | `T create` | `publish` | | Parent | | | | | Links | | | Span Create A, Span Create B | -| SpanKind | `PRODUCER` | `PRODUCER` | `PRODUCER` | +| SpanKind | `PRODUCER` | `PRODUCER` | `CLIENT | | Status | `Ok` | `Ok` | `Ok` | | `messaging.batch.message_count` | | | 2 | | `messaging.destination.name` | `"T"` | `"T"` | | From 3ef69e2462c3ca80b02e8f90cf134bd3f0ab3571 Mon Sep 17 00:00:00 2001 From: Anna Levenberg Date: Mon, 4 Dec 2023 14:29:37 -0500 Subject: [PATCH 10/14] Update CHANGELOG.md Co-authored-by: Alex Hong <9397363+hongalex@users.noreply.github.com> --- CHANGELOG.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 2343ac013c..3cf1506076 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -37,7 +37,7 @@ release. - Add `messaging.gcp_pubsub.message.ordering_key` attribute. ([#528](https://github.com/open-telemetry/semantic-conventions/pull/528)) - Add an example for gcp_pubsub asynchronous batch publish - ([#548](https://github.com/open-telemetry/semantic-conventions/pull/545)). + ([#545](https://github.com/open-telemetry/semantic-conventions/pull/545)). - Define how to set `process.runtime.name`, `process.runtime.version`, `process.runtime.description` for .NET runtime. ([#561](https://github.com/open-telemetry/semantic-conventions/pull/561)) From 4fc595da2649c2a853141cfe765beb576299a13e Mon Sep 17 00:00:00 2001 From: Anna Levenberg Date: Mon, 4 Dec 2023 14:30:11 -0500 Subject: [PATCH 11/14] Update docs/messaging/gcp-pubsub.md Co-authored-by: Alex Hong <9397363+hongalex@users.noreply.github.com> --- docs/messaging/gcp-pubsub.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/messaging/gcp-pubsub.md b/docs/messaging/gcp-pubsub.md index 2ce869f513..e9a3a8a12a 100644 --- a/docs/messaging/gcp-pubsub.md +++ b/docs/messaging/gcp-pubsub.md @@ -48,7 +48,7 @@ flowchart LR; | Span name | `T create` | `T create` | `publish` | | Parent | | | | | Links | | | Span Create A, Span Create B | -| SpanKind | `PRODUCER` | `PRODUCER` | `CLIENT | +| SpanKind | `PRODUCER` | `PRODUCER` | `CLIENT` | | Status | `Ok` | `Ok` | `Ok` | | `messaging.batch.message_count` | | | 2 | | `messaging.destination.name` | `"T"` | `"T"` | | From 6f912ef45a60726dfd71ecf70d4fcd7fd624d839 Mon Sep 17 00:00:00 2001 From: Anna Levenberg Date: Mon, 11 Dec 2023 11:10:01 -0500 Subject: [PATCH 12/14] Update docs/messaging/gcp-pubsub.md Co-authored-by: Johannes Tax --- docs/messaging/gcp-pubsub.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/messaging/gcp-pubsub.md b/docs/messaging/gcp-pubsub.md index e9a3a8a12a..9f374e22c4 100644 --- a/docs/messaging/gcp-pubsub.md +++ b/docs/messaging/gcp-pubsub.md @@ -55,6 +55,6 @@ flowchart LR; | `messaging.operation` | `"create"` | `"create"` | `"publish"` | | `messaging.message.id` | `"a1"` | `"a2"` | | | `messaging.message.envelope.size` | `1` | `1` | | -| `messaging.system` | `"gcp_pubsub"` | `"gcp_pubsub"` | | +| `messaging.system` | `"gcp_pubsub"` | `"gcp_pubsub"` | `"gcp_pubsub"` | [DocumentStatus]: https://github.com/open-telemetry/opentelemetry-specification/tree/v1.26.0/specification/document-status.md From 6138733f1500580ae2a2aabd3d330b2073a3ea6a Mon Sep 17 00:00:00 2001 From: Anna Levenberg Date: Mon, 11 Dec 2023 11:10:21 -0500 Subject: [PATCH 13/14] Update docs/messaging/gcp-pubsub.md Co-authored-by: Johannes Tax --- docs/messaging/gcp-pubsub.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/messaging/gcp-pubsub.md b/docs/messaging/gcp-pubsub.md index 9f374e22c4..95acf97d64 100644 --- a/docs/messaging/gcp-pubsub.md +++ b/docs/messaging/gcp-pubsub.md @@ -51,7 +51,7 @@ flowchart LR; | SpanKind | `PRODUCER` | `PRODUCER` | `CLIENT` | | Status | `Ok` | `Ok` | `Ok` | | `messaging.batch.message_count` | | | 2 | -| `messaging.destination.name` | `"T"` | `"T"` | | +| `messaging.destination.name` | `"T"` | `"T"` | `"T"` | | `messaging.operation` | `"create"` | `"create"` | `"publish"` | | `messaging.message.id` | `"a1"` | `"a2"` | | | `messaging.message.envelope.size` | `1` | `1` | | From 7a4b1c92401612acaa587e70991e0a768055db37 Mon Sep 17 00:00:00 2001 From: Joao Grassi Date: Wed, 10 Jan 2024 12:15:52 +0100 Subject: [PATCH 14/14] Move changelog entry to unreleased section --- CHANGELOG.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 73b328521a..4dfe18a4a3 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -18,6 +18,8 @@ release. - Add `azure_container_apps` to `cloud.platform` semantic conventions ([#615](https://github.com/open-telemetry/semantic-conventions/pull/615)) +- Add an example for gcp_pubsub asynchronous batch publish + ([#545](https://github.com/open-telemetry/semantic-conventions/pull/545)). ### Fixes @@ -63,8 +65,6 @@ release. ([#21](https://github.com/open-telemetry/semantic-conventions/pull/21)) - Add `messaging.gcp_pubsub.message.ordering_key` attribute. ([#528](https://github.com/open-telemetry/semantic-conventions/pull/528)) -- Add an example for gcp_pubsub asynchronous batch publish - ([#545](https://github.com/open-telemetry/semantic-conventions/pull/545)). - Define how to set `process.runtime.name`, `process.runtime.version`, `process.runtime.description` for .NET runtime. ([#561](https://github.com/open-telemetry/semantic-conventions/pull/561))