diff --git a/CHANGELOG.md b/CHANGELOG.md index 242003efd7..b4e3309a23 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -33,6 +33,8 @@ release. ([#399](https://github.com/open-telemetry/semantic-conventions/pull/399)) - Add cardinality warning about two opt-in HTTP metric attributes to all HTTP metrics. ([#412](https://github.com/open-telemetry/semantic-conventions/pull/412)) +- Remove outdated note about not recording HTTP `server.address` when only IP address available. + ([#413](https://github.com/open-telemetry/semantic-conventions/pull/413)) ## v1.22.0 (2023-10-12) diff --git a/docs/http/http-metrics.md b/docs/http/http-metrics.md index 3faf208c12..e48fe99cb3 100644 --- a/docs/http/http-metrics.md +++ b/docs/http/http-metrics.md @@ -133,8 +133,6 @@ SHOULD include the [application root](/docs/http/http-spans.md#http-server-defin if it's sent in absolute-form. - Host identifier of the `Host` header -SHOULD NOT be set if only IP address is available and capturing name would require a reverse DNS lookup. - Warning: since this attribute may be based on the `Host` header, opting in to it may allow an attacker to trigger cardinality limits, degrading the usefulness of the metric. @@ -215,8 +213,6 @@ Tracing instrumentations that do so, MUST also set `http.request.method_original if it's sent in absolute-form. - Host identifier of the `Host` header -SHOULD NOT be set if only IP address is available and capturing name would require a reverse DNS lookup. - Warning: since this attribute may be based on the `Host` header, opting in to it may allow an attacker to trigger cardinality limits, degrading the usefulness of the metric. @@ -320,8 +316,6 @@ SHOULD include the [application root](/docs/http/http-spans.md#http-server-defin if it's sent in absolute-form. - Host identifier of the `Host` header -SHOULD NOT be set if only IP address is available and capturing name would require a reverse DNS lookup. - Warning: since this attribute may be based on the `Host` header, opting in to it may allow an attacker to trigger cardinality limits, degrading the usefulness of the metric. @@ -433,8 +427,6 @@ SHOULD include the [application root](/docs/http/http-spans.md#http-server-defin if it's sent in absolute-form. - Host identifier of the `Host` header -SHOULD NOT be set if only IP address is available and capturing name would require a reverse DNS lookup. - Warning: since this attribute may be based on the `Host` header, opting in to it may allow an attacker to trigger cardinality limits, degrading the usefulness of the metric. diff --git a/docs/http/http-spans.md b/docs/http/http-spans.md index 4ef9bee100..fbb25146fc 100644 --- a/docs/http/http-spans.md +++ b/docs/http/http-spans.md @@ -379,8 +379,6 @@ SHOULD include the [application root](/docs/http/http-spans.md#http-server-defin if it's sent in absolute-form. - Host identifier of the `Host` header -SHOULD NOT be set if only IP address is available and capturing name would require a reverse DNS lookup. - **[5]:** Determined by using the first of the following that applies - Port identifier of the [primary server host](/docs/http/http-spans.md#http-server-definitions) of the matched virtual host. diff --git a/model/http-common.yaml b/model/http-common.yaml index 94ca81263c..e87556fb96 100644 --- a/model/http-common.yaml +++ b/model/http-common.yaml @@ -82,8 +82,6 @@ groups: if it's sent in absolute-form. - Host identifier of the `Host` header - SHOULD NOT be set if only IP address is available and capturing name would require a reverse DNS lookup. - - ref: server.port brief: > Port of the local HTTP server that received the request. diff --git a/model/metrics/http.yaml b/model/metrics/http.yaml index 474c99fa75..2cf9271775 100644 --- a/model/metrics/http.yaml +++ b/model/metrics/http.yaml @@ -15,8 +15,6 @@ groups: if it's sent in absolute-form. - Host identifier of the `Host` header - SHOULD NOT be set if only IP address is available and capturing name would require a reverse DNS lookup. - Warning: since this attribute may be based on the `Host` header, opting in to it may allow an attacker to trigger cardinality limits, degrading the usefulness of the metric. @@ -74,8 +72,6 @@ groups: if it's sent in absolute-form. - Host identifier of the `Host` header - SHOULD NOT be set if only IP address is available and capturing name would require a reverse DNS lookup. - Warning: since this attribute may be based on the `Host` header, opting in to it may allow an attacker to trigger cardinality limits, degrading the usefulness of the metric.