Replace system.network.state with network.connection.state #1632
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ChrsMark <[email protected]>
ChrsMark
force-pushed
the
fix_system_net_state
branch
from
ba65c2c
to
20e087c
Compare
mx-psi
approved these changes
Nov 29, 2024
model/network/registry.yaml
Outdated
| value: 'time_wait' | ||
| stability: experimental | ||
| stability: experimental | ||
| brief: "A stateless protocol MUST NOT set this attribute" |
There was a problem hiding this comment.
can we move that statement into note and in brief describe what that attribute stands for?
model/system/registry.yaml
Outdated
| @@ -152,6 +152,7 @@ groups: | |||
| brief: "Describes Network attributes" | |||
| attributes: | |||
| - id: system.network.state | |||
| deprecated: 'Removed, report network connection state with `network.connection.state` attribute' | |||
There was a problem hiding this comment.
Since this attribute is being deprecated here, it should be moved to this file: /model/system/deprecated/registry-deprecated.yaml
Signed-off-by: ChrsMark <[email protected]>
braydonk
approved these changes
Nov 29, 2024
dmitryax
approved these changes
Nov 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #308
Changes
ref: #308 (comment)
Merge requirement checklist
[chore]